Ckeditor5: Add confirmation check mark to the image upload animation

Created on 8 May 2018  路  5Comments  路  Source: ckeditor/ckeditor5

There should be :white_check_mark: when the upload finish sucessfully.

This is how it looks now in CKEditor 5:

before

This is how the animation looks like in Letters (with check mark):

after

Without it, upload looks incomplete.

image improvement

Most helpful comment

IMHO loader bar is appearing from the left to the right and this is the proper direction which user eyes should follow.

Maybe the bar also should be a bit bigger as it's also easy to miss - upload is very fast on your gifs.

Anyway I think that you guys now the best here, I've just dropping my 2垄 ;)

All 5 comments

BTW, apparently, there is something wrong with chack mark style, it is too small. It should be of course fixed.

One comment: I've totally missed that check mark while watching the animation for the first time. Wouldn't be better to put it on the left side of an image?

IMHO loader bar is appearing from the left to the right and this is the proper direction which the user eyes should follow.

cc @oleq

IMHO loader bar is appearing from the left to the right and this is the proper direction which user eyes should follow.

Maybe the bar also should be a bit bigger as it's also easy to miss - upload is very fast on your gifs.

Anyway I think that you guys now the best here, I've just dropping my 2垄 ;)

Keep in mind that the reason for this tickets is to unify upload UI in Letters and CKE 5, not to redesign it. If, by the way, you can make it better easily it would be great, but I remember we had a really long talk about the thickness of the bar, animation, etc and I don't want to reopen this discussion here. If you find something wrong in the upload UI feel free to report a separate ticket about it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pjasiun picture pjasiun  路  3Comments

oleq picture oleq  路  3Comments

wwalc picture wwalc  路  3Comments

MansoorJafari picture MansoorJafari  路  3Comments

Reinmar picture Reinmar  路  3Comments