Ckeditor5: [Safari] Link balloon is shown outside the view in manual tests if selection is collapsed

[maxbarnas]

Test: http://localhost:1030/build/modules/amd/tests/link/manual/link.

When I click on the first word in editor, the link balloon is shown as below:

[pomek]

It can be also reproduced in Chrome.

[maxbarnas]

@pomek I'll update the title.

[oskarwrobel]

Looks like a problem with getting offset of collapsed selection.
I can't reproduce it on Chrome.

[maxbarnas]

@oskarwrobel Yep, I can't reproduce it either. @pomek, can you provide steps to reproduce it, along with version of Chrome, type of screen (retina, non-retina), zoom factor, and all that stuff?

[pomek]

Eh. Yesterday I could reproduce it. Today I cannot. Maybe it was Firefox instead of Chrome. I am not sure. I would like to apologize for the mess.

[Reinmar]

There's a ticket on review which fixes some cases in positioning – maybe that it will fix this issue.

[oskarwrobel]

There's a ticket on review which fixes some cases in positioning – maybe that it will fix this issue.

I'm afraid it is a different issue.

[Reinmar]

Right... empty selection. I remember dealing with this in the past. It wasn't easy – I had to extend the range in some direction – otherwise the box was calculated incorrectly. And there were edge cases like empty blocks where the position had to be taken from the element.

[oskarwrobel]

Here is a fix for this: https://github.com/ckeditor/ckeditor5-ui-default/pull/91

[Reinmar]

Still as much reproducible as in the past. Could we fix it by positioning to the entire block if 0,0 cords were returned?

A full fix would be to inject an empty element inline in the place of the caret and positioning according to it. This may be required later on when we'll deal with scrolling to the caret on Enter, Delete, etc. but this is much more work.

[oleq]

https://github.com/ckeditor/ckeditor5-utils/pull/154 should fix the issue.