Ckeditor5: Make add/remove col labels clearer?

[tuomassalo]

I started translating the table plugin to Finnish and noticed that we have  Insert column before and Insert column after labels.

At least in Finnish, the UI would be a lot clearer to the user if it said "Insert column to the left" than "before".

Is this about LTR/RTL? If I translate "before" to "left", will it be incorrect on RTL text?

[tuomassalo]

Sidenote: I noticed that the merge labels do have left/right wording.

[Reinmar]

HI! We used the same labels as in CKEditor 4. It's a hard question, though, to understand whether the before/after words were dictated by RTL or taken from MS Word. But you may be right that RTL is one of the reasons for such a choice. I can see, for instance, that "before" in an RTL UI language in CKEditor 4 means "on the right" and in LTR UI language means "on the left". CKEditor 5 doesn't support RTLed UI yet so it will always do "on the left".

As for merge labels, I can't imagine "merge to before", "merge to after". There are 4 directions (up, right, bottom, left) so we need to be explicit. Which means that at least in this case we'll have left/right used in the future. That'd be an argument for aligning "insert row/col" labels to that too. Additionally, we'd avoid having to define what "before" means in RTL/LTR UI. It'll always be "left".

But before we proceed with this, I'd check a couple other editors to see if we won't be alone with this. That's never good too.

cc @oleq @dkonopka @Comandeer

[tuomassalo]

A related question: what is the process of updating translations from Transifex? Now that the table plugin messages have been translated, do I need to do something to get the updated Finnish translation to this Github repo?

[ma2ciek]

Hi, @tuomassalo.

After updating translations to the Transifex you don't have to worry about next steps, we'll pull updated translations and we'll update GH repositories.

[tuomassalo]

@ma2ciek Thanks! Any idea on whether the translations will be updated soon? I need those myself, and I'd rather not make a temporary fork because of thos few lines.

[Reinmar]

Together with the next release, so in ~3 weeks (no definitive date here).

[oleq]

I checked various editors including MS Word and Google Docs and the majority (including them) uses "Insert column left/right". So maybe to not confuse our users, I'd go with the voice of majority and just change the labels.