Citra: Lighting issues with ACNL, Smash Bros. 4, and ACHHD

[KillzXGaming]

This has been around since fragment lighting was first implemented, where you get shiny or over bright lighting on certain models or characters. I have no idea if this is something unimplemented so please correct me if this is the case on what causes this. I've tried searching issues and couldn't find any related issues on this , no idea if this is related to LUT lighting or anything or even just some mip map or rim lighting thing. These are currently the only titles i have so i do not currently know which other titles are affected by this.

Here are Citra screenshots:

In Game

Screenshots taken from an older master build from a few weeks ago but i can assure you i tested again just now on this one here:
https://github.com/citra-emu/citra/commit/bf14f4be2263b4769e97800b35951717192c2d1c

PC Specs:
i5 4670k
gtx 970
8gb RAM
Win 10

[khang06]

Also happens on some Sun/Moon NPCs.

[wwylele]

For Smash Bros 4, it is likely caused by unimplemented geometric factor (see here for G0 and G1). When rendering characters, the game has the geometric factor register bit enabled. I tried plugging in some geometric factor formula got from google, and the characters do look much more better

[KillzXGaming]

All games now have proper lighting!