Circuitverse: Stepper does not work in Preview/Embed mode

[fpintos]

Steppers do not seem to be responding to keyboard events in the preview window, even thou they appear selected when you click on them.

Repro:

• Navigate to a project that uses steppers, ex: https://circuitverse.org/users/1935/projects/5524
• In the preview pane, click one of the steppers (in this case, one of the two squares inside the pixel art box)
  
  
  
  • Stepper becomes yellow, indicating it is selected.
  
  
• Press up/down

Expected:

• For steppers to change value, as it happens in design mode.

Actual:

• No response from stepper.

[satu0king]

This should be easy to fix, by adding the listeners in embedListeners.js

[Ankitanvesh]

Hello @satu0king can I take up this issue

[Ankitanvesh]

I have had a look at the issue(and at embed Listeners.js). I wanted to know if it is needed to have the values of the steppers changed by using +,- keys as it happens in design mode or is it needed to have their values changed using up,down keys.

[fpintos]

The request in this case is to have the stepper work consistently in both cases. I think it is a good idea to support the arrow keys and -/+ keys as well in both cases.

[devu1999]

is this issue still open ?

[armudgal]

Hi @devu1999, @Ankitanvesh is working on it :)

[shubhankarsharma00]

@armudgal I already sent a pr 2 days ago fixing it

[armudgal]

@shubhankarsharma00 Aah, didn't see that, but again please inform us before starting to work on any issue. I have mentioned this before but it becomes really difficult for us to allocate issues that way.

@Ankitanvesh please talk to @shubhankarsharma00 and figure this out. Thanks

[Ankitanvesh]

@shubhankarsharma00 is trying to fix the original issue. Although I have been working on the issue plus the suggestion to add the arrowkeys for updating values of the steppers. I will leave it to @shubhankarsharma00 to fix the issue while I work on adding the arrowkey feature. Is it fine to continue that way @armudgal

[armudgal]

Sure, just wait for the other PR to get merged so that there are no conflicts :)