Cht-core: Guided tour erratic when user has no access to any tab

[ngaruko]

To Reproduce
Steps to reproduce the behavior:

1. Create a user with no access to tabs, say Data Entry access level
2. Login as the user created
3. A Select Tour modal is displayed as shown in the screenshot below.

Expected behavior
The tour should be disabled in cases like these

Screenshots

Environment

• Instance: localhost
• Browser: Firefox, Chrome
• Client platform: MacOS
• App: webapp
• Version: 3.9

Additional context
Not a practical use case scenario, thus low priority.

[jimbo108]

I've fixed this in my local branch -- still need to write a unit test and create PR. Aiming to do so in the next 3 days.

[garethbowen]

Ready for AT. This was developed by an external contributor so it's not available on the market but you can deploy using a dev environment on the jimbo108 fork, master branch.

[ngaruko]

Looks Ok. The tour does not show for users with no access to the app tabs. However, there is a small glitch in the behaviour: the tour pops ups again after being dismissed. Not sure if we really should spend much time of this feature @garethbowen ?

tour.mov.zip

[garethbowen]

I think that's unrelated to this. I think that's happening because when you select the tour it adds a tour=true parameter to the URL. Then when you reload that parameter is used to kick off the tour again. Can you test that in master and make sure the bug exists there too? If it is, please raise a separate issue for that.

[ngaruko]

@garethbowen Agree - Will raise a different issue

[garethbowen]

Merged. Thanks @jimbo108 !!