Cht-core: Tooltip showing as `logo`

[abbyad]

The logo for branding has a tooltip with just logo. Perhaps there is a way to set this that was missed. If so, we should document it.

Steps to reproduce:

• Hover over the logo in the top left corner of the app

What should happen:

• Should have some useful information (or nothing?), previously this used to be the version number. @amandacilek should would show the version number again, or something else?

What actually happens:

• The tooltip is logo

Environment:

• Instance: gamma.dev
• Browser: Chrome 72
• Client platform: Windows
• App: webapp
• Version: 3.4.0-beta.2

[Jodge]

This is a regression by white labelling feature, we should revert it back to display the version number on tooltip hover

[Jodge]

Ready for AT on branch 5531-logo

[amandacilek-zz]

I'm not sure how common of a UI pattern it is, but I'm fine showing the version number again on hover.

The previous tooltip of "logo" sounds more like information that should be in the code as alt text for accessibility purposes. In the case of alt text, "logo" would be fine, or we could further customize it to say whatever partner it is e.g. "Living Goods logo".

[Jodge]

Actually previous it was Title | version e.g. Medic Mobile | 3.5.0 so the change I have made has restored it back to that

[ngaruko]

LGTM

Back to you @Jodge to merge!

[abbyad]

Nice! @ngaruko does it also work when the title and/or logo is changed with the custom branding feature?

[Jodge]

@ngaruko could you also pull the latest code on this branch, I just realized when testing this change, the admin side specifically Images - Branding got broken, Ideally the test should confirm that you are able to change the title and the logo from the admin side as before

[garethbowen]

@ngaruko This is now ready for AT again.

[ngaruko]

It also works when the title and/or logo is changed with the custom branding feature @abbyad .
I guess that was the last fix @Jodge ?

[Jodge]

@ngaruko yes that's right, Thanks!