Cht-core: Feedback modal doesn't close after successful submission

[garethbowen]

Steps to reproduce:

1. Go to hamburger menu > Report Bug
2. Fill in any description
3. Submit

What should happen:

• The bug is submitted, the modal is closed, and a Snackbar is shown confirming the submission.

What actually happens:

• The modal stays open.

Nothing in the logs.
No indication of an error in the UI.

Environment:

• Instance: localhost
• Browser: Firefox
• Client platform: Ubuntu
• App: webapp
• Version: 3.5.0ish (master)

[garethbowen]

This was a regression caused by this line being removed in this commit: https://github.com/medic/medic/commit/f91bdea49bcabb988c3d1329cbf2792f897f42b0#diff-d43ea71e027c59879beb3bb530f132eaL54

[Jodge]

@garethbowen this is a regression and a quick fix, do we need AT here?

[garethbowen]

Yeah I think so. It's a quick fix but I may have broken something else along the way...

The only issues that skip AT are technical ones that don't affect the product in any way, eg: testing, build tools, documentation, etc

[garethbowen]

Ready for AT in 5522-remember-to-close-the-modal

[ngaruko]

Feedback is submitted but ... @Jodge
a) still shows error in console

b) add an empty json in the export feedback list
image

[garethbowen]

@ngaruko The only way I managed to reproduce this was by deleting the "feedback.submitted" translation, in which case I also got this in the log: "Translation for feedback.submitted doesn't exist". Can you confirm you see this in your log too?

The workaround is to provide the translation but I'll also patch the code so it doesn't fail if there's no translation.

[garethbowen]

I've merged a fix and the build has passed. Can you have another look please?

[ngaruko]

LGTM @garethbowen (Fresh install)
_Before_

_After_

[garethbowen]

Merged into master.