Cht-core: We should be able to add Keys with no translations

Created on 19 Dec 2018  路  3Comments  路  Source: medic/cht-core

Steps to reproduce:

  1. Go to the add translation form
  2. add a translation key but leave all translations blank.
  3. submit form

What should happen:

  • None of the keys are mandatory so you should be able to submit, but we should update the translation list UI to show the key with some styling (maybe italics?) so it's not just left blank..

What actually happens:

  • the translation is not actually created, only an empty row in the translations table
    image
    .
  • Instance: _(gamma-b.dev.medicmobile.org, etc)_
  • Browser: _(Firefox, Chrome)_
  • Client platform: _( MacOS)_
  • App: _(webapp, admin)_
  • Version: _(3.2.x, 3.4.x, etc)_
Configuration 2 - Medium Translations Bug

All 3 comments

@ngaruko, please edit the issue to include all the relevant info so that this issue is readable on it's own. Thank you!

LGTM.
Two things though
a) the format looks different from the rest of the keys (unbold and italic it seems)
b) the key cannot be renamed (in edit mode)

Are these expected behaviors @garethbowen

image

The key can't be renamed for any translations, so that's fine. I chose to change the styling because I wanted them to stand out.

Already merged. Closing.

Was this page helpful?
0 / 5 - 0 ratings