Chromeless: Allow setting of `headers`

Created on 27 Jul 2017  路  11Comments  路  Source: prisma-archive/chromeless

https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-setExtraHTTPHeaders

Consumers should probably be allowed to set headers for requests (helps with functional tests so that you can auth once and use headers on subsequent requests).

API enhancement

Most helpful comment

Publish this feature please. It's been almost a month.

All 11 comments

That's a great idea and could also be used for #29 maybe.

I would second this as well. Support for working with request and response headers is an important feature that's currently missing.

How could i get the header form chromeless? Now cookie() is available, is there any api for header ?

Can we merge this pull request in master and publish this changes with an updated version?

Publish this feature please. It's been almost a month.

@jahed we published lastest master as @sourcegraph/chromeless because we could not have used chromeless with our infrastructure otherwise, feel free to use that.

@schickling is there anything that is blocking this from getting released? That fork has been working fine for us for the past weeks

@felixfbecker no worries, I did the same thing. No point waiting for others when you can do it yourself in the meantime 馃憤 It turned out chromeless wasn't the solution I needed.

https://www.npmjs.com/package/@jahed/chromeless

@felixfbecker apologies we've been buried in work over the last 2 months. Would you be open to join as a maintainer and cut a release?

Sure. Might not be able to make a big maintenance/time commitment though, but may prep a PR to automate the release process to prevent this in the future :)

@jahed @gios released v1.4.0 (and deprecated our fork)

Cool, I'll delete mine when I get round to it. Think it's safe to close this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

maruidea picture maruidea  路  6Comments

adieuadieu picture adieuadieu  路  3Comments

ylscsdb picture ylscsdb  路  6Comments

Kikobeats picture Kikobeats  路  4Comments

just-boris picture just-boris  路  5Comments