Choco: Proxy bypass list with "*" will return regex quantifier parsing errors

[ferventcoder]

Say you add "*.localhost.com" to the proxy bypass list. Instead of configuring it properly, it will return an error with "parsing "*.localhost.com" - Quantifier {x,y} following nothing."

[swbsr]

I still get this error with 0.10.11. Wasn't the fix published with 0.10.10? The merge failed due to test coverage if Im not mistaken.

@ferventcoder What is the status on this?

[juspky]

I also still get this error and this causes me a lot of problems.
Hope this will be fixed soon

[ferventcoder]

@johlandabee interesting - I'll follow up on the issue you created as a followup.

This was definitely fixed and verified for 0.10.10 - no merge failed here.

[juspky]

I'm running Chocolatey v0.10.11
It is definitely not working.

[jpi-seb]

I have the same error with Chocolatey v0.10.11 on Windows 10.

ERROR: Exception setting "BypassList": "parsing "*.xx.xxxxxxxx.xx" - Quantifier {x,y} following nothing." The install of f.lux.install was NOT successful. Error while running 'C:\ProgramData\chocolatey\lib\f.lux.install\tools\chocolateyinstall.ps1'. See log for details.

Workaround : remove NO_PROXY env var before choco execution
SET NO_PROXY=

[t0r0X]

The documentation is very clear on this:
--proxy-bypass-list=VALUE ProxyBypassList - Comma separated list of regex locations to bypass on proxy. Requires explicity proxy (--proxyor config setting). Overrides the default proxy bypass list of ''. Available in 0.10.4+.

separated list of regex locations(!) Therefore the bypass expression --proxy-bypass-list='*.mycompany.tld' is wrong, and it should be --proxy-bypass-list='.*.mycompany.tld' (note the dot character before the asterisk).

So, in my opinion, this should not be fixed.

[swbsr]

@t0r0X Actually, most implementations do use globbing and not regex to match no_proxy entries. Infact, your example does not work for such, as it will match .xxx.mycompany.tld but not xxx.mycompany.tld. Changing the entries would probably work for chocolatey, but break other apps. Furthermore, .*.mycompany.tld means, the dots match any character. To make this technically correct, you'd have to escape them (.*\.mycompany\.tld) which would - yet again - not work for other applications.

[ferventcoder]

@johlandabee please open a new issue related to this. Can I ask that if you set the proxy bypass list INSIDE of chocolatey configuration whether it works with the regex described? And yes, . would match any character, including the literal .. Here's the link to the configuration setting - https://chocolatey.org/docs/chocolatey-configuration#proxy (proxyBypassList). Setting it here should not break other applications as they would not be using explicit Chocolatey settings.

[swbsr]

@ferventcoder That works. Thanks. Seems like the choco config weights more than the environment variable after all.

I've set the following:
choco config set --name proxyBypassList --value ".*\.tld,.*\.company.com"

[tremblaysimon]

It's a bit of pain that chocolatey doesn't properly use no_proxy environment variable and that we need a custom "no_proxy" setting for chocolatey...