Che: Add "Reload" button to the message panel from "GitHub authenticate".

Created on 17 Sep 2020  路  4Comments  路  Source: eclipse/che

Is your enhancement related to a problem? Please describe.

There is no "Reload" button in the message panel generated by the "GitHub authenticate" command.

Screenshot 2020-09-15 at 09 09 55

They can reload by their browser's menu or keybind for now. But it's better to provide "Reload" button for their user experience.

Describe the solution you'd like

"Reload" button is added. Like this.

Screenshot 2020-09-17 at 08 52 26

It calls navigator.window.reload(false) inside.

Describe alternatives you've considered

Providing "Reload" menu. (Probably the sub-menu in "File" section.)

Additional context

I've already implemented it on my PizzaFactory instance and tested by hand. I'm going to send PR.

areeditoche-theia kinenhancement severitP2

Most helpful comment

The vscode GitHub Pull Request plugin is going to be updated to the latest version: https://github.com/eclipse/che/issues/16741. In the latest version the authentication works through the authentication plugin API which is already introduced in theia: https://github.com/eclipse-theia/theia/pull/8402. It means that we will register our own GitHub authentication provider instead of injecting token to preferences so this notification will be removed.

I am OK to have it as a temporary improvement.

All 4 comments

Nice UX improvement!

The vscode GitHub Pull Request plugin is going to be updated to the latest version: https://github.com/eclipse/che/issues/16741. In the latest version the authentication works through the authentication plugin API which is already introduced in theia: https://github.com/eclipse-theia/theia/pull/8402. It means that we will register our own GitHub authentication provider instead of injecting token to preferences so this notification will be removed.

I am OK to have it as a temporary improvement.

@vinokurig Thank you for the good news.
I keep this PR as it will take a little time applying the authentication plugin API to Che-Theia.

As #16741 was closed, this issue is deprecated. I close this.

Was this page helpful?
0 / 5 - 0 ratings