Che: Build of che-theia is broken

[vitaliy-guliy]

Describe the bug

It looks like after merging this commit to Theia master, we cannot properly build che-theia.

In fact, yarn command finishes without errors, but after navigating to examples/assembly directory it turns out that the assembly is non built.

Only after running yarn run prepare @eclipse-che/theia-assembly in Theia root we can see that it's impossible to build package at all.

Steps to reproduce

• clone theia sources
• init che-theia by running che:theia init
• builtd by yarn

Expected behavior

The directory examples/assembly must have built che-theia.

Runtime

• [x] Openshift (include output of oc version)
• [x] minikube (include output of minikube version and kubectl version)

Screenshots

[tsmaeder]

They switched to eslint. Translation of directives should be pretty straightforward, though.

[benoitf]

It's more about typescript mode as well for now
attempts on fixing all issues is there: https://github.com/eclipse/che-theia/pull/609

[RomanNikitenko]

I get errors locally like:

So che-theia extensions can not be resolved.

@benoitf
Does that mean the cause of the issue is related to TypeScript build mode and should be resolved by adding some compilation.tsconfig.json with the corresponding references?

[RomanNikitenko]

thanks @benoitf for fix!
The PR was merged, so I'm closing the issue.

[benoitf]

@RomanNikitenko yes, upstream theia is using typescript build mode.
For building the image there is no 'gain' as we always start from scratch.
But in development mode, it's keeping a cache with incremental mode so it's faster.

I added (added by che-theia generator) in the example/assembly a tsconfig json file which references all tsconfig.json of eclipse che theia packages. Note that the order is important for now as it's how the compiler will do the graph. To enhance that, we should reference in each tsconfig.json file the dependencies through their tsconfig.json (we could reuse the @dependencies/devDependencies and generate that as well automatically)

Then, the root config [1] is now including as well a link to the tsconfig.json of example/assembly (modified again by the generator)

Some libraries have been updated upstream but I had to stick to an older version of mkdirp as ci.codenvycorp used to validate PR is using nodejs 8 (!!!!) while new versions of mkdirp are requiring nodejs >= 10

[1] : https://github.com/eclipse-theia/theia/blob/master/configs/root-compilation.tsconfig.json

[RomanNikitenko]

@benoitf
Yesterday I investigated how it works by adding compile.tsconfig.json files with the corresponding references as I commented here. But I tried it not on building images step, but using che-in-che, just to understand how it works. Today I can see your response, the changes for generator and dockerfile, it extends my knowledge and experience about it.

thank you very much for the detailed response!