Che: Allow to use PNG icons in plugin registry

[vitaliy-guliy]

Is your enhancement related to a problem? Please describe.

Now in the plugin registry when describing a plugin metadata we cannot use PNG image format. But this format is most commonly used in VS Code extensions. Just download any .vsix extension file, unpack in and open package.json. Icon field will point on PNG.

Now the icon https://www.eclipse.org/che/images/logo-eclipseche.svg is used for each plugin. On the UI it looks, to be honest, not pretty good

Describe the solution you'd like

Allow to use PNG for the plugin icons.

[skabashnyuk]

AFAIK svg was requested by authors of plugin-viewer application.
CC @l0rd @slemeur

[l0rd]

@skabashnyuk I don't see any issue with that

[l0rd]

cc @amisevsk @ibuziuk

[amisevsk]

If the plugin viewer supports it, disabling the .svg check is a one-line fix on the plugin registry.

[vitaliy-guliy]

Is plugin-viewer application alive?
Where can I see/test it?

[amisevsk]

I was assuming the plugin viewer refers to the plugins sidebar in theia (ctrl+shift+j)

[skabashnyuk]

plugin viewer

It is a separate app https://github.com/eclipse/che-plugin-registry/pull/72

[vitaliy-guliy]

It is a separate app eclipse/che-plugin-registry#72

It looks it has been moved here https://github.com/che-incubator/che-plugin-viewer/pull/1/files
But there is more than 7 month of inactivity.

[amisevsk]

Is there any verdict on this issue? Can we support png icons?

[vitaliy-guliy]

Now it's possible to use any URI referencing an image