Che: Can not create a new pull request from GitHub plugin

Created on 11 Jul 2019 · 19Comments · Source: eclipse/che

Description

Can not create a new pull request from GitHub plugin

Reproduction Steps

Add GitHub pull-request plugin
Open a workspace with a project cloned from GitHub
Checkout to a new branch and commit some changes.
Call Create Pull Request command

WRONG: Create process freezes, error occurred:
root ERROR [hosted-plugin: 11878] (node:11878) UnhandledPromiseRejectionWarning: TypeError: s.window.createInputBox is not a function

OS and version:
7.0.0
Diagnostics:

areeditoche-theia kinbug severitP1 teaplugins

Source

vinokurig

Most helpful comment

fixed by theia-ide/theia#5187

vinokurig on 7 Aug 2019

🎉2

All 19 comments

@vparfonov : Could you please give an estimate on this issue. Would really prefer to have that for 7.0.0

slemeur on 23 Jul 2019

@slemeur There is a PR that fixes the bug: https://github.com/theia-ide/theia/pull/5187 AFAIK @JPinkney is working on it's comments

vinokurig on 23 Jul 2019

Yes, I'm still working on fixing up the comments. The reason its taking so long is I have to go back and re-do the way the createQuickPick api works (QuickInput/InputBox API's are all directly related) before I can start some of the improvements requested. The way that createQuickPick api was originally implemented doesn't allow for InputBox to be completed

JPinkney on 23 Jul 2019

@l0rd + @rhopp + @tsmaeder + @nickboldt : This issue is making a lot of sense to be in 7.0.0. Having github plugin working with the ability of doing a PR is a must have.

slemeur on 23 Jul 2019

This issue is making a lot of sense to be in 7.0.0. Having github plugin working with the ability of doing a PR is a must have.

Agree.

rhopp on 23 Jul 2019

@vinokurig and I have agreed to split the work for the last few fix-ups on the QuickInput/InputBox/QuickPick API's so we can get this in for 7.0.0

JPinkney on 23 Jul 2019

👍1

Thanks @JPinkney and @vinokurig !

slemeur on 23 Jul 2019

@slemeur I have to disagree that this is a must have: there is a very simple workaround: open the PR on github.com. Not every bug and missing feature is 7.0.0-worthy.

tsmaeder on 23 Jul 2019

@slemeur to me, before pushing a PR, you have to go through git commit ... so https://github.com/eclipse/che/issues/13874 is a must have

sunix on 23 Jul 2019

For me this is a '7.0.0' but not a severity/blocker. Rather a severity/P2.

l0rd on 24 Jul 2019

The value added by the ability to automate the creation of a PR and provide the reviewer link is key to Che. It highlights a big promise of Che in how it can help developers being more efficient.

If we don't have it, it'll be a functional gap from the targeted scope of the release. Something we have not been able to deliver.

slemeur on 24 Jul 2019

@slemeur time-quality-features, pick any two.

tsmaeder on 24 Jul 2019

@vparfonov What is the update on this?

slemeur on 2 Aug 2019

fixed by theia-ide/theia#5187

vinokurig on 7 Aug 2019

🎉2

fixed by theia-ide/theia#5187

vinokurig on 8 Aug 2019

Is it fixed in Che-theia 7.0.0-next ? milestone seems to be 7.0.0.