Che: Confusing dialogs are shown when a project is cloned

[sunix]

Description

With new git vscode extension, che-theia is not behaving as expected during initial clone of project. The project should be cloned without any prompt for the user but currently a couple of prompt dialogs are shown to the user.

Maybe we shouldn't use that theia command and invoke git directly (https://github.com/eclipse/che-theia/blob/master/plugins/factory-plugin/src/theia-commands.ts#L74). Or maybe there are some default options to set.

Reproduction Steps

Started the workspace with project to clone, like:

chectl workspace:start -f <(chectl devfile:generate -name=che7-readme-update-stable --git-repo=https://github.com/eclipse/che --dockerimage=sunix/git-devtools)
  ✔ Retrieving Che Server URL...http://che-che.192.168.39.13.nip.io
  ✔ Verify if Che server is running
  ✔ Create workspace from Devfile /dev/fd/63

Workspace IDE URL:
http://che-che.192.168.39.13.nip.io/dashboard/#/ide/che/che7-readme-update-stable

Theia starts successfully but ask to select a (git) repository:

It shouldn't ask anything as it was before. Moreover selecting Cancel abort project cloning and that should not happen neither.

Anyway selecting folder /projects/ works and the project is cloned successfully (and a nice spinner is shown indicating that the cloning is happening).

After the project is cloned a couple of dialogs are shown to the user:

And if you do not make the right choice, we end up with strange folders in the explorer

OS and version:
rhel, chectl and minikube

[ibuziuk]

have the same issue on prod-preview after update to '7.0.0-rc-3.0' - https://github.com/redhat-developer/rh-che/pull/1474

[vparfonov]

@ibuziuk Maybe 7.0.0-rc-4.0-SNAPSHOT ?

[ibuziuk]

@vparfonov nope, was able to repro against stable 7.0.0-rc-3.0 upstream release

[vparfonov]

hm, ok thanks

[rhopp]

@vinokurig @vparfonov When can we expect solution to this issue? I'm asking because it's currently breaking happy path tests and I'm trying to decide whether it's worth it to implement workaround in Happy Path tests.

[vparfonov]

@rhopp, we work on it just now, will ping you soon

[sunix]

@vinokurig maybe quick way to fix it is to invoke git directly instead of using the vscode command 'git.clone'

https://github.com/eclipse/che-theia/blob/master/plugins/factory-plugin/src/git.ts#L57

to replace

https://github.com/eclipse/che-theia/blob/master/plugins/factory-plugin/src/theia-commands.ts#L74

[vinokurig]

@sunix Right now I am preparing a new binary of vscode git that solves this problem.

[johnmcollier]

I should also note that this shows up every time the Che workspace is accessed (rather that just the first time). Also, when you reload the workspace in the browser, if you select the same folder as before, it reclones the projects, creating duplicates in the workspace.

[vinokurig]

eclipse/che-theia:7.0.0-rc-3.0 image is rebuilt with the patched vscode git extension

[sunix]

@vinokurig are you saying that you are forking vscode git ?

[vinokurig]

Yes, it's a kind of a fork https://github.com/che-incubator/vscode-git

[johnmcollier]

Will the fix for this be pushed/merged to eclipse/che-theia:next?

[johnmcollier]

@sunix @vinokurig I'm still seeing duplicate clones when refreshing/reloading a Che workspace with eclipse/che-theia:7.0.0-rc-3.0, so I've opened https://github.com/eclipse/che/issues/13796

[sunix]

@sunix @vinokurig I'm still seeing duplicate clones when refreshing/reloading a Che workspace with eclipse/che-theia:7.0.0-rc-3.0, so I've opened #13796

Thanks