Charts: [bitnami/metallb] Invalid metrics jobLabel

[alex1989hu]

Which chart:
bitnami/metallb:0.1.13

Describe the bug

Service "metallb-speaker-metrics" is invalid: metadata.labels: Invalid value: "app.kubernetes.io/name": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

Service "metallb-controller-metrics" is invalid: metadata.labels: Invalid value: "app.kubernetes.io/name": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

To Reproduce
Steps to reproduce the behavior:

1. Deploy Helm Chart bitnami/metallb:0.1.13 with prometheus.serviceMonitor.enabled=true
2. See error

Expected behavior
Valid job label is set.

Version of Helm and Kubernetes:

• Output of helm version:

version.BuildInfo{Version:"v3.2.0", GitCommit:"e11b7ce3b12db2941e90399e874513fbd24bcb71", GitTreeState:"clean", GoVersion:"go1.13.10"}

• Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:58:59Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.0", GitCommit:"9e991415386e4cf155a24b1da15becaa390438d8", GitTreeState:"clean", BuildDate:"2020-03-25T14:50:46Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

Additional context
Regression introduced in https://github.com/bitnami/charts/pull/2616

[alex1989hu]

/cc @Cellebyte

[Cellebyte]

@alex1989hu could someone review the changes.

[andresbono]

Thanks for reporting and providing a fix!

[Cellebyte]

@andresbono and @alex1989hu you're welcome :)