Chapel: Comments referencing closed issues

[ben-albrecht]

The following files contain comments that refer to closed issues. I assume many of them are TODOs to improve an implementation when that issue is closed, but I have not yet verified every single one (this list was generated by a script):

• [x] modules/internal/ChapelDistribution.chpl : #5311 (closed)
  
  
  
  • updated in #11251
  
  
• [x] modules/internal/ChapelDistribution.chpl : #5311 (closed)
  
  
  
  • updated in #11251
  
  
• [x] modules/standard/IO.chpl : #7960 (closed)
  
  
  
  • updated in #11241
  
  
• [x] modules/packages/LinearAlgebra.chpl : #9926 (closed)
  
  
  
  • updated in #11236
  
  
• [x] compiler/passes/resolveIntents.cpp : #5266 (closed)
  
  
  
  • updated in #11246
  
  
• [x] compiler/codegen/codegen.cpp : #5887 (closed)
  
  
  
  • updated in #11247
  
  

See the list including open issues here.

[ben-albrecht]

It looks like some of these are pointing to closed PRs. I'll update the script to filter PRs out, and will update this list.

updated

[bradcray]

Can your script do a 'git blame' to determine who inserted the comments so that they can verify that they should be removed? Or should that burden fall to the person who closed the issue?

[ben-albrecht]

Can your script do a 'git blame' to determine who inserted the comments so that they can verify that they should be removed?

Sure thing - updated above with git blame output attached.

Or should that burden fall to the person who closed the issue?

I'd be comfortable leaving that burden on the author of the original work-around.

[ben-albrecht]

FWIW, I intend to add this script to util/devel at some point.

[bradcray]

Aw man, @ben-albrecht swooped in and stole the fun of clicking a checkbox! :'o

[ben-albrecht]

Pinging @mppf && @benharsh to make them aware that their name appears in the git blame output above.

[benharsh]

I'll look at the ChapelDistribution comments.

[mppf]

PRs #11246 #11247 will fix the ones blamed on me

[benharsh]

My two items were resolved by #11251

[ben-albrecht]

Thanks everybody!