Cellprofiler: Enable Regular Expression help window to be selected when in the Regex Editor

Created on 20 Sep 2016  Â·  9Comments  Â·  Source: CellProfiler/CellProfiler

At the moment the Regex Editor is modal so the user can't scroll through the Regular Expression help - it'd be really useful if this help could be made available when the user has the editor open.

Bug

Most helpful comment

https://regex101.com/#python produces results that work into or out of CP every time in my hands.

All 9 comments

I’m inclined to remove the regular expression editor entirely and point people to some of the excellent web-based regular expression editors, e.g. http://regexr.com/

Nonetheless, I’m keeping this open since it’s a bug for an existing feature.

Thanks, @nickholway!

I actually find the editor useful so would be disappointed to see it go.

On 20 September 2016 at 17:35, Allen Goodman [email protected]
wrote:

I’m inclined to remove the regular expression editor entirely and point
people to some of the excellent web-based regular expression editors, e.g.
http://regexr.com/

Nonetheless, I’m keeping this open since it’s a bug for an existing
feature.

Thanks, @nickholway https://github.com/nickholway!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CellProfiler/CellProfiler/issues/2350#issuecomment-248339168,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsjF7QfQeM8wUDLFfadHPGf2Sg-wnUZks5qr_09gaJpZM4KBsXy
.

Definitely understand; it's a matter of maintenance costs... We are in the midst of trying to get CellProfiler into shape so we can maintain it more easily and add features more easily. So we are having to make tough decisions about what features are core to CellProfiler and which can be managed outside of CellProfiler without too much pain. If you have a minute, we'd appreciate if you detail how bad it would be to use an outside editor vs one built in to CP. We would of course have the help for that setting point to an external resource like what Allen mentioned. Would that generally suffice do you think?

I've generally like having the regex editor there, so like @nickholway, I'd be sad to see it go. But arguably, if a person is knowledgeable enough to even know what a regex is (certainly not everybody!), then they're knowledgeable enough to use a helpful regex url.

I just tried putting the default regex from CP into regexr.com and it is
flagged as an error. I'm not opposed to using an external webpage as long
as it works. In the light of Ann's message, I can think of things in CP
that are more important to keep though; I'd describe it as a "nice to have".

On 21 September 2016 at 11:30, Anne Carpenter [email protected]
wrote:

Definitely understand; it's a matter of maintenance costs... We are in the
midst of trying to get CellProfiler into shape so we can maintain it more
easily and add features more easily. So we are having to make tough
decisions about what features are core to CellProfiler and which can be
managed outside of CellProfiler without too much pain. If you have a
minute, we'd appreciate if you detail how bad it would be to use an outside
editor vs one built in to CP. We would of course have the help for that
setting point to an external resource like what Allen mentioned. Would that
generally suffice do you think?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CellProfiler/CellProfiler/issues/2350#issuecomment-248559373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsjF_7MBOF2_jFS8IirRSJHDWPc5yQbks5qsPk_gaJpZM4KBsXy
.

I just tried putting the default regex from CP into regexr.com and it is flagged as an error.

Well … was it an error?

The ? in "^(?P.*)" was flagged as "invalid target for quantifier".
So from a regex PoV you could say it's correct, from a CP PoV it's wrong :)

On 21 September 2016 at 17:31, Allen Goodman [email protected]
wrote:

I just tried putting the default regex from CP into regexr.com and it is
flagged as an error.

Well … was it an error?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CellProfiler/CellProfiler/issues/2350#issuecomment-248649174,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsjF1I40TxnpJTO3GYrtt4xqcTKVYfPks5qsU3egaJpZM4KBsXy
.

RegExr doesn't like named capture groups: https://github.com/gskinner/regexr/issues/16. There might be another utility out there that does.

https://regex101.com/#python produces results that work into or out of CP every time in my hands.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AetherUnbound picture AetherUnbound  Â·  4Comments

AnneCarpenter picture AnneCarpenter  Â·  9Comments

mcquin picture mcquin  Â·  5Comments

dlogan picture dlogan  Â·  9Comments

bethac07 picture bethac07  Â·  9Comments