Cbioportal: Oncoprint re-renders after adding a new clinical track

[pieterlukasse]

Steps to reproduce:
1- Load BRCA provisional TCGA study
2- Do a simple query on some genes
3- Click some of the clinical tracks. The oncoprint will completely re-render. See screenshot below:

Desired solution:

• The current tracks should stay. Oncoprint should not completely re-render. Just like when adding pre-calculated track such as "Total mutations" and "Mutation spectrum" (after "Fraction Genome altered" has been added).

[adamabeshouse]

@alisman for UX should we just use the full loader rectangle for the initial load, after that a smaller loader?
@pieterlukasse the oncoprint isn't actually rerendering during this, it's just being obstructed by a loader while the data loads

[adamabeshouse]

@pieterlukasse this is a good catch we should address, but we're going to put this off until after the release

[jjgao]

add a zip line.

[adamabeshouse]

do we still want to do a zip line?

[pieterlukasse]

sounds good to me, as long as the oncoprint stays on the screen while new parts are added to it.

[adamabeshouse]

@pieterlukasse the oncoprint won't be usable anyway while the new parts are added to it, but it could still be usable while the data is loading. Knowing that, is it still desirable to keep it visible?

[pieterlukasse]

@adamabeshouse yes, I think it is just odd to have the whole thing disappear behind a grey curtain if all I am doing is just adding an extra clinical track.

[adamabeshouse]

@pieterlukasse I agree.. but to me it seems odd as well to have the oncoprint be visible when we cant interact with it. Maybe it would be better if we just made the gray transparent?

[jjgao]

Maybe show the loading message (small region) on top of OncoPrint?

[pieterlukasse]

@adamabeshouse I like @jjgao' s idea: perhaps just a small region with a progress bar?

[adamabeshouse]

I don't like that because then the oncoprint becomes unusable but theres no visual indication of that. What I think we should do is put a small "loading data" message somewhere while the data loads, but keep the oncoprint visible, since the oncoprint is still usable then. But then while the oncoprint renders, we'll put a transparent loader block on top.

[pieterlukasse]

@adamabeshouse sounds good :+1:

[adamabeshouse]

is this still something we'd like to do?

[pieterlukasse]

yes, if you ask me. @jjgao ?

[jjgao]

I've moved it to Icebox. Let's not worry about it.

[pieterlukasse]

is icebox like a backlog or more like an archive?

[jjgao]

icebox is like a garbage can ;) -- bottom of priority.

[jjgao]

closing this. If still desired, please open in the main repo.