Cbioportal: installation map feedback

[tmazor]

The map looks awesome @jtquach1 ! Here's some feedback:

• [x] 1. Might be worth a minor wording change on the homepage. In this text: "Have you installed and used cBioPortal? Fill out the survey here to have your lab featured on the map!" instead of "your lab" might be better to say "your installation"
• [x] 2. How about replacing "Selected instance details" with "Details" and when nothing is selected, put text underneath to say "Select an instance in the table or map to see additional information"
• [x] 3. Not sure if this is just me, but I find it slightly counter-intuitive to have the selected waypoint on the map as a lighter color than all the others.
• [x] 4. I think coordinates can be removed from the details table
• [x] 5. When zoomed in to a level where states/provinces are visible, can the country borders be thicker or somehow distinct from state borders? For example when I zoom in on Europe, it would be nice to still know where the country lines are:
  
• [x] 6. @pieterlukasse noted earlier that the Netherlands has lines drawn at the city(?) level rather than at the province level
• [ ] 7. we should add some human QC of the data in the spreadsheet before showing it in the map, just in case people enter inappropriate content. There are probably many ways to do this, but one suggestion is to add a column where one of us has to enter "yes" or "ok" before the data can load in the map
• [x] 8. for consistency, replace "installations" with "instances"
  

[jtquach1]

Thanks Tali!

1. Just pushed this change here: https://github.com/cBioPortal/cbioportal-frontend/pull/3410/commits/51f028578bbb18873c9fd1d55a21c4bee1c9576d
2. Done (revised from below comment)
   
3. Done (seen above)
4. Done
   
5. Done! I'm thinking of getting some other countries in there too, just because some of the original borders from the simple map are still jagged (e.g. on Switzerland).
   
   
   
   
6. Mexico's borders are thick on some states, though
7. Revised the Netherlands to display at the province level (below)
8. Modified backend script to filter out rows whose 'Approved' column doesn't read "Yes" (case-insensitive)
9. Done
   

[jtquach1]

Hm, that explains why the Netherlands looks so granulated. I'll try to find a map that has the lines drawn at the province level.

Edit:

[jtquach1]

For 3), I had the table row and Marker be light blue when selected (they're actually very close shades of blue, but the row's blue has the same darkness as its gray rows). Sjoerd suggested to pick a more contrasting color for the highlight on the map.

So, making the markers light blue by default (with dark blue highlight) might lead to the contrast issue Sjoerd mentioned. I played around with the cBioPortal colors using coolors and wondered if I should use a shade of light blue that's more saturated?

This is the current default Marker color:

This is the new Marker highlight color I had in mind (contrasted with default color):

This is the current Marker highlight color (contrasted with default color):

[tmazor]

@jtquach1 your proposed color update with 2C609C looks good to me!

[tmazor]

@jtquach1 for 2, sorry I think my request wasn't clear - I was imagining something like this:

This way the header never changes, and the second line with text can just be replaced by the table when something gets selected.

[jtquach1]

@jtquach1 your proposed color update with 2C609C looks good to me!

I forgot to mention, I try to keep the marker highlight and table row highlight the same (for consistency), so this is the current view:

Although I'm not sure if the dark table rows look okay with that shade of blue.
Or instead I could make them have the default marker color like so:

Luke also suggested I could animate the Markers when they're selected to make them pop out more.

[jtquach1]

I like "Selected instance details" more (that suggestion was from JJ) since "Details" alone feels kind of general- I'm not sure..

[tmazor]

@jtquach1 now that I see it in your screenshot, I agree, let's call it "Selected Instance Details" and then keep the line of text I proposed below it. All the other updates are looking great!

[tmazor]

Also @jtquach1 - I like the idea of animating the markers when they are selected. I'm not sure I know exactly what that means, but I like doing something to help the user find their marker of interest.

[jtquach1]

Here is the current view with animated highlighted markers and a darker highlight:

[jtquach1]

I've just revised the highlighted marker animation so it only grows and shrinks back to original size once:

[tmazor]

awesome @jtquach1 !