Cb-tumblebug: Remove obsolete comments in `securitygroup.go`

[seokho-son]

What would you like to be enhanced
: Remove obsolete comments in image.go

Why is this needed
: Code enhancement

Proposed solution

Remove following comments from cb-tumblebug/src/core/mcir/securitygroup.go

• // 2020-04-13 https://github.com/cloud-barista/cb-spider/blob/master/cloud-control-manager/cloud-driver/interfaces/resources/SecurityHandler.go
  
  
  
  • /* type SpiderSecurityReqInfo struct { // Spider Name string VPCName string SecurityRules *[]SpiderSecurityRuleInfo //Direction string // @todo used?? } */
  
  

[seokho-son]

ref #848
@FionaFR could you contribute on this issue ? :)

[FionaFR]

ref #848 @FionaFR could you contribute on this issue ? :)

Yes Thanks. I will work on it right away.

[jihoon-seo]

/assign @FionaFR
@FionaFR Thank you for your interest on this project!

[FionaFR]

Hi again. I had made the changes , pull request and merge but it shows up in my Hacktoberfest as "Project not participating". All of the merges I did says the same thing. Do you know why is this happening?

[FionaFR]

Can you please label this as hacktoberfest?

[seokho-son]

Hi again. I had made the changes , pull request and merge but it shows up in my Hacktoberfest as "Project not participating". All of the merges I did says the same thing. Do you know why is this happening?

@FionaFR
I cannot find your PR :) Please share the link of PR.
Maybe you opened your PR to your own forked repositiry?

If I know correctly, to be recoreded as a Hacktoberfest you need to open a PR to this upsteam repository (cloud-barista/cb-tumblebug) not your forked repository.
When your PR has been merged by a maintainer (I am), I will put the label for hacktoberfest-accepted.

[FionaFR]

https://github.com/FionaFR/cb-tumblebug/pull/2

I had already merge it

[hermitkim1]

@FionaFR, thank you for sharing the link 👍

From my observation, I can find 2 merge histories to the forked main.

• Older one is for removing obsolete comments of main.go
• Lastest one is for removing obsolete comments of securitygroup.go

I'm worried about the older history, which is out of scope for this issue.

I suggest 2 options:
[Option 1]

1. Newly create a branch from upstream/main
2. Apply the proposed solution
3. Open a pull request

[Option 2]

1. Open another pull request from FionaFR-securitygroup_go_updated
2. Review the PR
3. Squash and merge, only if the contribution of main.go is acceptable for the maintainers

@seokho-son, which of the two options would you prefer? 😄

[FionaFR]

HI @hermitkim1

I tried doing both but my changes has already merged. So there is no more editing I can do once I fork and copy the securitygroup.go from the original code

[hermitkim1]

@FionaFR, I think it's possible to do option 1 in your local repository.

Please let me know if you need any help.

But, I'd like to wait for the maintainer's answer because option 2 looks easier than option 1 to resolve this issue 😃

[seokho-son]

Hello ~ :) @FionaFR
Let me guess your situation here ;)

As I mentioned before, you need to open a PR to this repository (cloud-barista/cb-tumblebug) not to a your forked repository (FionaFR/cb-tumblebug).

Opening and Merging a PR https://github.com/FionaFR/cb-tumblebug/pull/2 yourself in your forked repository (let me say this is ORIGIN: https://github.com/FionaFR/cb-tumblebug) does not affect to
UPSTREAM(https://github.com/cloud-barista/cb-tumblebug)

• [Current situation] FionaFR:main <-- FionaFR:FionaFR-securitygroup_go_updated

Please open a PR to this repository :)
You can open a PR to this repository here: https://github.com/cloud-barista/cb-tumblebug/compare

• [Open PR from where and to] cloud-barista:main <-- FionaFR:FionaFR-securitygroup_go_updated

To open a PR to UPSTREAM repository, you can check a guide document from Github. https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

After you open a PR this this repo (cloud-barista:main), the maintainers will review the PR and possible to request updates of the PR if necessary.

---

@hermitkim1 Thank you for your help !! Both Option 1 and Option 2 are fine for us, I think we can handle any commit issues from a new PR from @FionaFR.
Anyway, I guess the main difficulty here is about confusion on targeted remote repository for a PR.

[seokho-son]

Hi @FionaFR
I just want to check everything regarding this issue is going well :)

[seokho-son]

@FionaFR this issue has been closed by #888
If you are looking for another good-first-issue let us know :) We can open issues for new contribution!