Cb-tumblebug: Rename `CoreGetAllBenchmark` function name

Created on 9 Oct 2021  Β·  5Comments  Β·  Source: cloud-barista/cb-tumblebug

What would you like to be enhanced
: Change CoreGetAllBenchmark function name

Why is this needed
: The func name is not appropriate.

Proposed solution
: Search CoreGetAllBenchmark. Replace it with RunAllBenchmarks

  • cb-tumblebug/src/api/grpc/server/mcis/control.go

    • 516,22: result, err := mcis.CoreGetAllBenchmark(req.NsId, req.McisId, mcisObj.Host)
  • cb-tumblebug/src/api/rest/server/mcis/control.go

    • 763,22: result, err := mcis.CoreGetAllBenchmark(nsId, mcisId, req.Host)
  • cb-tumblebug/src/core/mcis/benchmark.go

    • 195,4: // CoreGetAllBenchmark is func to get alls Benchmarks
    • 196,6: func CoreGetAllBenchmark(nsId string, mcisId string, host string) (*BenchmarkInfoArray, error) {

κ΄€λ ¨ μ†ŒμŠ€ κ°„λž΅ μ„€λͺ…:

  • cb-tumblebug/src/core/mcis/benchmark.go μ—λŠ” 각 CSP 및 λ¦¬μ „μ˜ VM Spec의 μ„±λŠ₯을 μΈ‘μ •ν•˜κΈ° μœ„ν•œ λ²€μΉ˜λ§ˆν‚Ή κ΄€λ ¨ ν•¨μˆ˜λ“€μ΄ ν¬ν•¨λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.
  • κ·Έ 쀑, CoreGetAllBenchmark λŠ” MCIS에 ν¬ν•¨λœ λͺ¨λ“  VMλ“€μ—κ²Œ 닀쀑 ν•­λͺ©("cpus", "cpum", "memR", "memW", "fioR", "fioW", "dbR", "dbW", "rtt")에 λŒ€ν•œ μ„±λŠ₯ 평가λ₯Ό ν•˜κ³ , κ·Έ 정보λ₯Ό CB-TB μ„œλ²„κ°€ μœ„μΉ˜ν•˜λŠ” 곳에 λ‚΄λΆ€ 파일(benchmarking.csv)둜 μ €μž₯ν•΄ μ£ΌλŠ” κΈ°λŠ₯을 μ œκ³΅ν•©λ‹ˆλ‹€.
  • ν•΄λ‹Ή ν•¨μˆ˜λŠ” REST 및 gRPC μΈν„°νŽ˜μ΄μŠ€λ₯Ό ν†΅ν•΄μ„œ ν˜ΈμΆœν•  수 μžˆμŠ΅λ‹ˆλ‹€. κ΄€λ ¨ μ†ŒμŠ€λŠ” μ•„λž˜μ— μœ„μΉ˜ν•©λ‹ˆλ‹€.

    • REST API: - cb-tumblebug/src/api/rest/server/mcis/control.go

    • gRPC API: - cb-tumblebug/src/api/grpc/server/mcis/control.go

CB-TB의 μ†ŒμŠ€μ½”λ“œλŠ” λŒ€λΆ€λΆ„ 이런 ν˜•νƒœλ‘œ ꡬ성이 λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. (생각보닀 간단)

  • CB-TB μ‹œμŠ€ν…œμ΄ κ΅¬λ™λ˜λ©΄, REST API μ„œλ²„ / gRPC μ„œλ²„ / μ˜€μΌ€μŠ€νŠΈλ ˆμ΄μ…˜ 관리 λͺ¨λ“ˆ μ΄λ ‡κ²Œ 3κ°€μ§€κ°€ 고루틴(μ“°λ ˆλ“œμ™€ λΉ„μŠ·ν•œ κ°œλ…)으둜 λ³‘λ ¬λ‘œ μƒμ‹œ ꡬ동 λ©λ‹ˆλ‹€.

  • REST API λ₯Ό λ°›λŠ” ν•¨μˆ˜ -> ν•΄λ‹Ή κΈ°λŠ₯을 μˆ˜ν–‰ν•˜λŠ” ν•Έλ“€λŸ¬

  • gRPC API λ₯Ό λ°›λŠ” ν•¨μˆ˜ -> ν•΄λ‹Ή κΈ°λŠ₯을 μˆ˜ν–‰ν•˜λŠ” ν•Έλ“€λŸ¬
  • μ˜€μΌ€μŠ€νŠΈλ ˆμ΄ν„°λŠ” μ‹œκ°„μ— 따라 주기적으둜 λ™μž‘ν•˜λ©° -> μ§€μ •λœ μ•‘μ…˜(ν•¨μˆ˜)을 μˆ˜ν–‰
enhancement good first issue Hacktoberfest

Most helpful comment

@seokho-son I found typos in your comment so @limsg1234 was not assigned to this issue as you desired.
So I have assigned @limsg1234 by myself so others can know whether this issue is already taken by someone from the issue list.

Thank you

All 5 comments

Waiting for a response from CA21 mentee :)

μ•ˆλ…•ν•˜μ„Έμš”. μ œκ°€ ν•΄λ³΄κ² μŠ΅λ‹ˆλ‹€.

/assing @limsg1234

@seokho-son I found typos in your comment so @limsg1234 was not assigned to this issue as you desired.
So I have assigned @limsg1234 by myself so others can know whether this issue is already taken by someone from the issue list.

Thank you

MyLovelyTypo !! ;)
Thanks.

Was this page helpful?
0 / 5 - 0 ratings