Map#++ is associative and should also form a Monoid with Map.empty as the identity :)
One thing to note is that this one needs to follow the MapInstancesBinCompat0 example - i.e.
MapInstancesBinCompat1 trait and add the instance there, MapInstancesBinCompat0 and add MapInstancesBinCompat1 there. cats.tests.MapSuiteI would like to take that one :)
Hey @wojciechUrbanski! Do you mind If I take this from you?
Hey @alexeygorobets. Sure, go on. Unfortunately i am a little bit occupied right now and cannot continue working on this one.
Thank you @wojciechUrbanski !
hi @kailuowang
Am I correct that I need to create a separate trait
trait AllInstancesBinCompat4 extends SortedMapInstancesBinCompat1 with MapInstancesBinCompat1
for maintaining binary compatibility?
@alexeygorobets that's correct. Thanks!
Fixed by #2744.