Cataclysm-dda: NPC hands player liquid contents of container rather than container, spilling it on the ground

[kenneth-ellis]

Describe the bug

When an NPC tries to give player a liquid item such as a bottle of cough syrup, the NPC tries to give just the liquid contents instead of the bottle, resulting in the liquid just being poured out on the ground and wasted, instead.

Steps To Reproduce

1. Use the "Want to share some useful items with me?" option on an NPC who has a bottle of liquid in inventory.
2. Watch as they dump the contents of the bottle on the ground at your feet.

Expected behavior

NPCs should generally hand you the container a liquid is in along with the content rather than dumping it on the ground. Probably the same should be true of small items like a bottle of aspirin, etc.

Versions and configuration

• OS: Windows
  
  
  
  • OS Version: 10.0 1909
  
  
• Game Version: 0.E-4875-g97984d6 [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  No Fungal Monsters [No_Fungi]
  ]

[Duck13Tales]

NPC:

[kenneth-ellis]

@Duck13Tales - lol, yeah that's pretty much how I imagined it -- NPC just looks at me with a big troll-face grin and says, "Oh, you really need some cough syrup huh? Here ya go!" and pours it all over my boots. 😁

[wapcaplet]

Confirmed, still an issue in 0.E-6177-g 9f4a1b841d

[Maleclypse]

Would this be fixed by making liquids NO_TRADE but still adding their value to the container's value?