Cataclysm-dda: Discolored item names in the dark.

[8street]

Is your feature request related to a problem? Please describe.
In darkness, in reality, objects are not visible well enough. I can make them discolor in game. How do you like it? I myself am not sure if this is worth doing, but it will give the game more realism.

Describe the solution you'd like
Discolored item names in the very dark. All items color in the very dark becomes c_dark_gray color. In inventory, advanced inventory, pickup window, shif-v window and everywhere at all.

Code example, item.cpp:

nc_color item::color_in_inventory() const
{
    // TODO: make a const reference
    avatar &u = g->u;

    //if player in very dark then return dark color
    float light = u.fine_detail_vision_mod();
    if ( light >= 4.0f ) {
        return c_dark_gray;
    }
...

Describe alternatives you've considered
Do nothing.

Additional context
Before

After in very dark

Please comment how do you like this?

[Zireael07]

Many characters have night vision from mutations so I assume "bad night vision" isn't a case for them.
Also I believe the colors in UI are a matter of quality-of-life, not actually seeing items?

[ZhilkinSerg]

Yeah, I don't think that inventory is something that you look at, but something that you know you have in your posession.

[8street]

Well, in the dark, the player can neither read nor craft. Why can he easily pick up items?
I agree, we don’t touch the color in the inventory, advanced inventory. But I can change the colors in the pickup and shift-v window. And of course, I will make exceptions for night vision. More opinions?

[Ulysses2]

Yeah, the colored labels aren't actually representative of the item's color, but of its qualities. Like for instance, CBMs that you don't have yet are green. And it doesn't give you any information you didn't already have from the item's name, it's just a matter of convenience, so I don't see the point really.

[8street]

Well, can still pick up items by touch. Only selected is visible. Although this is probably really overkill.

[Zireael07]

Definitely overkill IMHO.

[8street]

OK. The community does not need this. Closed.