Cataclysm-dda: Multidrop of too many items freezes the game
follow up to https://github.com/CleverRaven/Cataclysm-DDA/issues/36554
Describe the bug
When multidropping different items, game freezes and crashes.
Steps To Reproduce
Steps to reproduce the behavior:
- Have mulitple items ready to drop
- Drop the bass
- Freeze the game.
Expected behavior
Non Freezing.
Versions and configuration
- OS: Windows
- OS Version: 10.0 1903
- Game Version: 0.D-10976-ga39fc83 [64-bit]
- Graphics Version: Tiles
- Mods loaded: [
Dark Days Ahead [dda],
0Graphical Overmap [0Graphical_Overmap],
Stats Through Skills [StatsThroughSkills],
SpeedyDex [speedydex],
Nonperishable Overhaul [Nonperishable_Overhaul]
]
Lamandus
All 17 comments
Please follow issue template. Game version information is CRUCIAL.
ZhilkinSerg
on 3 Jan 2020
Please follow issue template. Game version information is CRUCIAL.
aye, updated!
Lamandus
on 3 Jan 2020
I can confirm this. Playing 10110, Android 64-bit on a pixel 3xl. Happens when using the "/" menu and I press ",".
HudsonMC16
on 3 Jan 2020
- OS: Windows
- OS Version: 10.0 1903
- Game Version: 0.D-10976-ga39fc83 [64-bit]
- Graphics Version: Tiles
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food]
]
It's not just the dropping of large amount of items that triggers the issue, it's dropping several stacks that have multiple items. In this save you can reproduce the bug by dropping the entire inventory.
It looks like the game is not actually frozen, per se, because dropping 5 stacks causes a massive slowdown but eventually resolves.
Kelenius
on 3 Jan 2020
And in this save, dropping the entire inventory happens without an issue, because every stack only has one item.
Kelenius
on 3 Jan 2020
Can confirm, dropping eg. 50 cash cards and 5 glass bottles caps out one core and allocates all available memory.
1n17
on 3 Jan 2020
Yeah, that fix made the game kaput.
Unrepentant-Atheist
on 3 Jan 2020
I tried to drop items on the latest experimental build and i use windows 10, but it only dropped one at a time for me. it was not a huge stack of items, but for some reason dropping my stack of 3 rags on the floor resulted in only one being dropped at a time
Alapaga
on 3 Jan 2020
I am unable to reproduce this crash on my dev environment; windows 10, VS2019, static executable
KorGgenT
on 3 Jan 2020
I am unable to reproduce this crash on my dev environment; windows 10, VS2019, static executable
You have to try to drop multiple stacks of items.
jlon125
on 3 Jan 2020
I am unable to reproduce this crash on my dev environment; windows 10, VS2019, static executable
You have to try to drop multiple stacks of items.
tried kelenius's save, dropped everything in my inventory including my clothing. this was the third test, after dropping 300 plastic chunks and 100 mutant meat in addition to all of my clothing
KorGgenT
on 3 Jan 2020
I am unable to reproduce this crash on my dev environment; windows 10, VS2019, static executable
You have to try to drop multiple stacks of items.
tried kelenius's save, dropped everything in my inventory including my clothing. this was the third test, after dropping 300 plastic chunks and 100 mutant meat in addition to all of my clothing
Well that's odd, but it's happening on all three computers I've tried. I wonder what is different for you?
jlon125
on 3 Jan 2020
confirmed on my machine - Linux - lubuntu with Kelenius save.
ghost
on 3 Jan 2020
In the issue for the "can only drop 2 at a time", they hypothesized that it was #36205 that caused the issue. At this point, even if the new method is theoretically better from an optimization standpoint, might it not be better to just revert that one back until we identify the issue it's causing and manage to find a good fix for it?
Ker-Nes
on 3 Jan 2020
OS: Windows
- OS Version: 10.0 1903
- Game Version: 0.D-10976-ga39fc83 [64-bit]
- Graphics Version: Tiles
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food]
]It's not just the dropping of large amount of items that triggers the issue, it's dropping several stacks that have multiple items. In this save you can reproduce the bug by dropping the entire inventory.
It looks like the game is not actually frozen, per se, because dropping 5 stacks causes a massive slowdown but eventually resolves.
Ah. Good to know, I don't need to save scum/force quit then. Getting the same. More items dropped more chance, but does happen when just a few items dropped. Specifically for me dropped in a vehicle, but not dropped much on the floor to know if that is a candidate too.
TechyBen
on 3 Jan 2020
I have this issue as well when dropping a stack of 32 threads onto ground. If I drop then one by one, they can be moved without a crash, only the 'M'ove all command will crash it.
Have tried numerous scenario's (eg: dropping on bench, ground, travois, different squares etc) all with same result.
Interesting to note that it only crashes when moving items FROM inventory.
https://imgur.com/C5dYhvT
Above picture is for v10976, but it also crashes on: "Cataclysm DDA version 0.D-10977-g4a734f0"
NyarlathotepZERO
on 3 Jan 2020
v: 0.D-10977-g4a734f0
I had this problem while playing yesterday but not today. The difference is that yesterday i had autoloot (loot all) turned on because i was foraging the forest. Today i remembered to turn it off.
MaksOta
on 4 Jan 2020
Related issues
ituluwituluwzev
路
3Comments
2birdie
路
3Comments
busterbogheart
路
3Comments
Coolthulhu
路
3Comments
Cyrano7
路
3Comments
Most helpful comment
In the issue for the "can only drop 2 at a time", they hypothesized that it was #36205 that caused the issue. At this point, even if the new method is theoretically better from an optimization standpoint, might it not be better to just revert that one back until we identify the issue it's causing and manage to find a good fix for it?