Cataclysm-dda: Clothing items collide that shouldn't

[ymber]

Describe the bug

Wearable items that shouldn't collide in clothing layers often do. This is most visible in SKINTIGHT and BELTED.

Steps To Reproduce

Steps to reproduce the behavior:

1. Wear knee pads and a leg ammo pouch at the same time.

Expected behavior

Clothes that are normally worn over each other do not cause extra encumbrance penalties. Clothes that occupy the same layer but different areas do not cause extra encumbrance penalties.

Screenshots

Versions and configuration

• OS: N/A
• Game Version: Current master at fe0e3ded3c0801632951bd63fafa6c2cb7111e6f
• Graphics version: N/A
• Mods loaded: N/A

[wapcaplet]

The examples you provided look like legitimate clothing layer conflicts to me:

• knee pads and leg ammo pouch are both strapped to the legs
• boy shorts, compression shorts, and leggings are all worn next to the skin on the legs
• sports bra and compression top are both worn next to the skin on the torso

In your screenshots, the messages indicate why the items are in conflict - wearing multiple items on the same layer, on the same body part, is adding the extra encumbrance. My understanding of the clothing layer system is that's how it's supposed to work. Have I misunderstood, or am I missing something?

[ymber]

Yeah this is expected behavior for the current system. I want to improve the system so we've got better granularity in body part coverage and layers. Compression shorts are a bad example but we have some things that collide in the same layer that are normally worn together. The knee pads and ammo pouch shouldn't collide because theyre on different parts of the leg. I meant to handle this one before 0f but I got caught up with other things.

[Rivet-the-Zombie]

Maybe we could add separate segments for thigh, knee, and calf? Same for the arms, and maybe the torso (abdomen, chest, neck, back) so that your scarf wouldn't be trying to occupy the same space as your mouthguard &etc.