Cataclysm-dda: Any tool that relies on ammo_remaining() is turned unusable with UPS toolmod

[ave-]

Describe the bug

Any tool that relies on ammo_remaining() to count charges inside is turned completely unusable if UPS toolmod is applied to it.

Steps To Reproduce

Steps to reproduce the behavior:

1. Create a player with UPS or bionic UPS (commercial cyborg prof can be used to test this).
2. Spawn something like radio, multi-cooker, portable game, etc.
3. Spawn an UPS conversion mod.
4. Insert this mod into the spawned item.
5. Try to use it.

Expected behavior

Tool should be able to rely on UPS charges.

[dunstad]

I did a quick look through iuse.cpp and as far as I can tell, these are the tools that should still be affected:

radio, lajatang, tazer, portable game, vibrator, tablet, electric handcuffs, foodperson mask, autoclave, multicooker

If there could be other occurrences of this kind of bug outside of iuse.cpp, let me know.

A few of those are a bit weird. I'm not sure why you would ever make the handcuffs or foodperson mask run off UPS, but I don't mind making it possible. I'm also not sure if there's any UPS with enough power to handle the autoclave, although I suppose the UPS CBM might work in theory.

If anyone wants to confirm that any of the above tools are in fact not working with the UPS mod at the moment, it would help get through them faster. Otherwise I'll get to it eventually.

[dunstad]

Here's how my initial investigation went:

• radio: can turn on without power, seems to prompt when deactivating?

• lajatang: fails to turn on

• tazer: appears to work fine...

• game: fails to turn on

• vibrator: appears to work fine...

• tablet: appears to work fine...

• handcuffs: doesn't appear to use magazine style batteries at all, can't be UPS modded

• foodperson mask: UPS modding the mask, wearing + activating it, then removing the battery from the UPS crashes the game

• autoclave: refuses to start, even when the UPS is using a heavy plutonium battery (10k charges)

• multicooker: refuses to start

I suspect the tools that fail to turn on at all are probably easy fixes. (lajatang, game, autoclave, multicooker)

The ones that seem to work fine might benefit from using the new function anyway, but they're the lowest priority for me. (tazer, vibrator, tablet)

The rest seem like they have more specific problems, and will probably each require more time to fix. (radio, handcuffs, foodperson mask)

[dunstad]

If you install the UPS mod on your e-ink tablet, it cannot play songs.

If you install the UPS mod on a firearm kit or gunsmith kit, you cannot use it to craft. You can use it to craft if you have a duplicate that uses a conventional battery charge and it doesn't have enough charge to complete a batch craft.

Source: https://www.reddit.com/r/cataclysmdda/comments/dfprxk/i_think_im_finished/

[sick-trigger]

the electric firestarters nobody uses are also affected

This tool doesn't have enough charges.
You can't reload a electric firestarer+1 (UPS)!