Cataclysm-dda: The bycicle's engine starts up.

[Fris0uman]

• Windows 10
• Build 8502
• Tiles

What's wrong ?
Bycicle has no engine but a foot_crank and yet :

Not only it's engine starts up but it's also humming.

How to reproduce

• Spawn a bicycle
• Start the bicycle
• Listen to the soft humming of it's engine

Describe the solution you'd like
Well game should tell you something like "You reach for the pedals." or "You start pedaling." and it should either make a clacking noise or no noise.

Additional context

A brief glance at the code showed that "The %s's engine starts up." should only be displayed for non muscle engine so I don't know where it's going wrong since foot_crank is define as a muscle engine in the jsons.

[Epictyphlosion]

Really strange, not sure if I can fix this one. But I would suggest something like "You get on the bicycle"

[MyculplantKatze]

you:"vroom vroom"
Zombies: "WTF silly human that is not a car!"

[GoLoT]

And you can get the the bycicle's engine fails to start message sometimes. I didn't try to reproduce but I had it happen when trying to start a dynamo with a motorbike alternator.

[Zombiemanpig]

And you can get the the bycicle's engine fails to start message sometimes. I didn't try to reproduce but I had it happen when trying to start a dynamo with a motorbike alternator.

Maybe one of the foot pedals is broken and your foot slipped off before you were able to "start" the bike and your character didn't feel right making the noises 😆

[Epictyphlosion]

Maybe the noises are caused by a card someone stuck in the back wheel? Lol

[WilliamtheCardboardBox]

Really needs a fix.

[Treah]

LOL im pretty sure this was done to try and fix the problem with the bike having negitive sound causing a crash. But not sure why it was fixed again...

[Fris0uman]

So it seems that in Line 1974 of activity_handlers.cpp !veh->is_engine_type( e, "muscle" ) actually returns true for the bicycle.

[ifreund]

Caused by #26967 as far as I can tell

[kevingranade]

Fixed by #28222