Cataclysm-dda: Titanium Skeletal Bracing Cannot Be Installed on NPC Followers

[Nameless-Survivor]

The titanium skeletal bracing CBM is a passive CBM which increases maximum carry weight, but it cannot be installed on your NPC followers like all the other passive CBMs.

How to Replicate:
Attempt to install Titanium Skeletal Bracing CBM on a follower.

Version: Current Experimental.

Proposed Action To Fix:
Add to allowed CBMs for NPCs.

[Night-Pryanik]

What messages appear in this case?

[Nameless-Survivor]

Just the standard one for when you can't install a cbm on somebody else.

[Pupsi-Mupsi]

Hello Nameless-Survivor!

Right now it is not meant to be implanted in any npc.
It could be done by adding "flags": [ "BIONIC_NPC_USABLE" ] to datajsonbionics.json.
But should we change it... i'm not sure. What do you think? Why should it be npc-useable?

{
"id": "bio_weight",
"type": "bionic",
"name": "Titanium Skeletal Bracing",
"description": "Titanium bracing has been installed onto your elbows, knees, and spine, making them far better at handling strain. Your carrying capacity is increased by 20 kilograms, or about 44 pounds.",
"occupied_bodyparts": [ [ "TORSO", 8 ], [ "ARM_L", 3 ], [ "ARM_R", 3 ], [ "LEG_L", 3 ], [ "LEG_R", 3 ] ],
"flags": [ "BIONIC_NPC_USABLE" ]
},

[Nameless-Survivor]

Why shouldn’t you be able to increase their carry weight? All the other passive bionics are useable by them, and last I heard the only reason NPC’s can’t use active bionics is because the coding hasn’t been implemented yet for them to decide when/how to use them. I think not adding the flag may have just been an oversight.

[mlangsdorf]

This CBM should have the flag that let's it be installed on NPCs.

[Pupsi-Mupsi]

Great. So, since there is an agreement. I will make a PR to change it.