Cataclysm-dda: Reloading shotguns from the ground with full inventory erases ammo, crashes game.

[notazed]

v0.C-27430-ge5d2149 - Build 7327
Windows 10 - Tiles

Mods active:
None

Expected behavior

Reload the shotgun without picking it up. Or require the player to wield it to reload, if their inventory is full.

Actual behavior

Strange behavior, sometimes reloading, sometimes game eats the ammo, sometimes the game says "Can't reload orange juice (fresh), can't reload cranberry juice (fresh), etc" even though no such items exist on or anywhere near my character, lol. Sometimes it just crashes the game.

Steps to reproduce the behavior

1. Fill inventory to max.
2. Spawn shotgun and ammo on the ground.
3. (R)eload the shotgun.
4. Try not to crash.

[notazed]

Similar results with other guns: AR-15 with 30 round stanag magazine

lol

[BorkBorkGoesTheCode]

@notafed Cannot confirm in 0.C 27466. What objects are in your inventory before the crash?

[notazed]

I simply filled the rest of my inventory with rags. And I left the empty shotgun and the ammo on the ground next to me. Tried reloading them with [r] (without picking it up and wielding it) and got various different bugs out of it.

Edit: Tested again with 0.C-27472 - Build 7734. Still getting bugs. At one point it made me drop the rags and pick up the shotgun when I tried reloading, but I reset the test and all the other times it either ate the ammo or didn't load it at all. Eventually the game crashed again.

[Night-Pryanik]

Can confirm on latest experimental. Just got my inventory filled both for weight and for volume and tried to reload gun laying on the floor.

It seems that reload_finish activity is trying to get targets for reloading from ether in this case.

[ghost]

I had the same problem trying to reload a welder from ground with full inventory.

[Night-Pryanik]

There is a comment in game.cpp:
https://github.com/CleverRaven/Cataclysm-DDA/blob/26f02fbbcea0825d2612bf40349e1de582583aa0/src/game.cpp#L9389-L9390
so we might need to explicitly make player to pick up weapon or tool prior to reloading.

[lucasmr]

I believe #24413, #24266 and #23735 are related to this. There should be a full rewrite of the reload action, using game_menus::inv. I'll take a look.