Caseflow: Cannot delete contention connected to an issue in ratings

[leikkisa]

The contention is connected to an issue in ratings and cannot be deleted. Removing Contention failed. System error.

Sentry alert
https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/4164/events/279664/

[leikkisa]

I looked at one instance of this. The Request Issue does not have any decision issues, and none of the Veteran's rating issues that we're getting back have the same contention_reference_id. Also all of the ratings have a promulgation_date before the receipt date of the Request Issue. So at first glance, it does not seem to be caused by the contention getting a new rating issue, unless it is not getting returned to us.

[pkarman]

10099 improves the error message (one small step)

[pkarman]

The case of RequestIssue 11152 on RequestIssuesUpdate 264 is that the issue has a DTA Error disposition on it already.

[leikkisa]

The End Product got cleared on the 26th, but the status didn't get synced until the 27th, and the issue removal was on the 26th, so maybe we need to sync the EP before loading the edit page. Once an EP is cleared, they can't edit anymore.

[pkarman]

maybe we need to sync the EP before loading the edit page

yes that makes sense, and is consistent with what we already did at intake start in #9519

[Sjones352]

@pkarman can you please provide instructions on how I can test this in UAT?

[pkarman]

Validation would be very similar to #9519

• create a claim review.
• look the console for the claim review's UUID
• clear or cancel its EP in VBMS
• attempt to edit the claim review e.g. /higher_level_reviews/:uuid/edit
• confirm you get a message saying it cannot be edited.

[Sjones352]

Going to wait for the sync job before I can try to edit it

[pkarman]

@Sjones352 the point is not waiting for the sync job. It should sync automatically when you try and edit it.

[Sjones352]

This how I did it and it can actually be edited

I can even remove the rating that I added

[pkarman]

ah ok I was wrong in my validation instructions. I didn't realize that "CAN" and "CLR" are treated differently in Caseflow.

Instead of this step:

clear or cancel its EP in VBMS

we should

clear its EP in VBMS

[Sjones352]

Passes UAT