Caseflow: Improperly updating tasks after checkout flows

[mdbenjam]

Currently when completing a checkout flow we don't always properly update the tasks. i.e. if you do an attorney checkout flow the completed task doesn't end up under the completed tab. They do show up after reloading the page. We need to reload tasks after completing a checkout flow.

[joeyyang]

Just want to chime in to say that this behavior also exists when adding an admin action to a task — i.e., the tab contents and numbers do not update when a task has been sent away for an admin action.

[lowellrex]

Screencap of the on hold count decreasing (legacy appeals disappear) after an attorney creates an admin action for an AMA appeal:

[lowellrex]

One problem we are able to reproduce and pinpoint is the issue of tasks related to cases with new documents disappearing from the "on hold" tab. It appears as if the onHoldTasksByAssigneeCssIdSelector selector is causing this because it is filtering out tasks related to cases with new documents.

Steps to reproduce:

• Log in as BVASCASPER1
• Make sure there is a task related to a case with new documents (can probably spoof this by hard coding some appeal IDs locally in AppealsController.new_documents
• Load /queue (see a flicker in the count of tasks that are on hold, from larger number to smaller number)
• Comment out the request to hit the new documents endpoint in QueueLoadingScreen
• Load /queue (see only the larger number in the on hold tab count, no flicker)
• Click on the "on hold" tab.
  
  
  
  • This should fire requests to the new documents endpoint and the on hold count will decrease at this point in time.
  
  

Acceptance criteria

• [x] First pass at this ticket will only attempt to solve this problem for attorneys.

Looks like this is happening because it was originally written to accomodate the set of tabs for VLJ support staff and we have an extra tab there called "Pending action" which is where that task with new documents ends up.

[lowellrex]

We can reproduce one bug by replicating this test that creates an admin action for a legacy appeal, makes the case disappear from the "assigned" tab but one does not appear in the "on hold" tab.

[tomas-nava]

not pointed; we need more investigation to understand whether there's a single cause for every case. It would be helpful for front- and back-end engineers to pair and track exactly where the task data is coming from and how to reload it. @tomas-nava @annekainicUSDS @hschallhorn

[hschallhorn]

So I've done some looking into adding an admin action to a legacy appeal and there are two separate issues.

1. The parent task does not show up in the on hold tab
   We don't actually handle the newly created tasks that are returned with the request as we do when we create an admin action on an AMA task. This includes colocated tasks that were assigned by this attorney/judge which will show up in the on hold tab the on hold tab. This is an easy fix that I already have written up and tested. ✅
2. The parent task remains in the assigned tab
   The legacy tasks assigned to the user are not returned with this request. These are grabbed from a separate endpoint when the page is loaded, which is why the queue is correct after a reload.

[hschallhorn]

Screencap of the on hold count decreasing (legacy appeals disappear) after an attorney creates an admin action for an AMA appeal:

This issue is caused by calling onReceiveAmaTasks which sets all amaTasks rather than merging as onReceiveTasks does. This overwrites any colocated tasks from a legacy appeal that the attorney has assigned. Another easy and texted fix ✅

[laurjpeterson]

hey @hschallhorn - i see your PR on this issue has been merged! can this ticket be closed?