Caseflow: CHECK ON AUGUST 18: VBMS requires postal codes for Germany and Caseflow does not

[leikkisa]

Discovered this bug with this Sentry error:
https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/1917/

The Veteran model only requires USA and Canada to have zip codes in validation.

[leikkisa]

@abbyraskinUSDS @suzchap Can one of you check this out and see what is required, and if we are missing any other countries? We want to make sure it matches code policy requirements if they exist for this. If we don't know, let me know and I can ask VBMS if knows.

[abbyraskinUSDS]

Hm yeah, this seems like a VBMS question. We saw this sentry error a couple weeks ago, too, and Shane was not familiar with it.

[abbyraskinUSDS]

phoning a friend named @aroltsch who dealt with something similar for Dispatch a long time ago...

[aroltsch]

It appears to me other countries require postal code. This error is for Germany and zip code we are sending is nil.

:country=>"Germany", :zip_code=>nil

However, I don't remember dealing with it personally. I found a few tickets Shane filed with VBMS team:
https://github.com/department-of-veterans-affairs/dsva-vbms/issues/77
https://github.com/department-of-veterans-affairs/dsva-vbms/issues/80

cc @abbyraskinUSDS @leikkisa

[leikkisa]

I am double checking with VBMS if we just need to add Germany (and potentially other countries) to the list of countries requiring postal code in the Veteran model.

I looked at the other tickets and I think this is unrelated to the OVR address type issue because it's an INT address type and I don't think it's a military address (the Veteran is not in the military anymore and I didn't see any of those other codes).

[leikkisa]

VBMS checked and it appears that Germany is allowed to come through without a zip code in V5, but for some reason we were still using v4. Some things to check:

• Are we setting it to use V5 when we make the request?
• Is there a V5 feature flag that needs to be turned on in prod?
  
  
  
  • If so, are we ready to do that?
  
  

[leikkisa]

So the feature flag for V5 was not turned on in prod. We just turned it on. I think we can move this to Validation, and if we don't see the error for a while we can move it to done?

[leikkisa]

New update, we now believe this is due to an issue with VBMS prod (it also worked with V4 in UAT) and will be fixed in the next release, 15.1 on August 18, 2018.

https://rtc01.aide.oit.va.gov/jazz/web/projects/VBMS.BIP.Development#action=com.ibm.team.workitem.viewWorkItem&id=703723

[abbyraskinUSDS]

@abbyraskinusds to add a ticket for the error message

[leikkisa]

@abbyraskinUSDS I don't think we need to make a separate ticket, I just made a quick PR against this ticket, and we can keep the ticket open until the VBMS fix is in.

[leikkisa]

Happening for Australia too.

[kahlouie]

Sally has emailed VBMS to see if the bug fix on their side got deployed this weekend. Will get a pr up for the revert with the blocked label until we get confirmation.