Cartodb: Improve Builder's wayfinding

Created on 24 Nov 2017  路  10Comments  路  Source: CartoDB/cartodb

All 10 comments

do we have an inventory of modals where the new wayfinding should be applied? with the current modals setup we end up with some modals as you can see below

pageshot of refugio lizara bisaurin refugio lizara tracks carto 2017-12-02-1125 34

in the meantime I'm doing a workaround to keep the close button in the legacy modals, but keep in mind this is a temporary hack

@piensaenpixel @arianaescobar

Does this issue also includes changing the color for the layers to this ones https://github.com/CartoDB/design/issues/1036#issuecomment-346604367?

@arianaescobar

@matallo It should be applied in every modal, the thing is that we have different styles of modals, being that one you added a legacy one. That change should be applied to all the new ones that have the header left-aligned (until we update the old ones, which hopefully won't take long because having different ways of closing a modal could potentially be very confusing).

@rubenmoya Yes, that's part of the issue :)

@arianaescobar as much as I don't like it, we'll do it phased as currently despite having several modals styles they all share the same code

in any case, I'm applying the breadcrumbs to the new modals 馃憤

Oki! Let me know if you have any other doubt.

I'm leaving the close button in the modals below, too

pageshot of untitled map carto 2017-12-02-1336 44

Uploaded to ruis in staging, at the end we've decided not to split it, so all the changes should be there. The acceptance steps are in https://github.com/CartoDB/cartodb/pull/13185, I've been checking and I can't see anything weird, but could you take a look @CartoDB/design? If you need a staging user tell me!

ping @CartoDB/design

I'm on it!

In production! 馃殌

Was this page helpful?
0 / 5 - 0 ratings