Cartodb: Organization login not for not org users

Created on 23 Dec 2016  路  16Comments  路  Source: CartoDB/cartodb

Steps to Reproduce

  1. Go to an organization login page.
  2. Login with a user outside the organization.
  3. You'll be logged in.

Expected result

It should fail.

Additional info

It's not a concern: you login as usual, without any relation to the org. Anyway, it might look strange.

Backend

Most helpful comment

Sorry, you're right. Yeah, the signup was the only source of confusion.

All 16 comments

Opening this one up for discussion. How do you think this should work?

My first idea would be to use some kind of error message, asking the user to go to the general login, which I think is the more explicit solution. A quick & dirty sketch:

screenshot_20170102_203028

A concern, is that it may expose that the username is not a member of the organization. This could be avoided with a more generic "Username/password invalid. Not a member of team? Go to the general login." for all failed logins.

More ideas:

  • Automatically redirect to the general login without notice and ask the user to login again (but I think this is the worst of both worlds, bad feedback and more user interaction required).
  • We can also keep the current behaviour, which I don't think is that bad. I don't think many users see the difference between the org login and general login (although they may have custom colors and logo), and it could be confusing to ask the user to login elsewhere.

Another extra thing we can consider is to disable the login page for user subdomains (javitonino.carto.com/login) and automatically redirect to the central login (carto.com/login). This makes it easier to avoid problems logging in between multiple clouds (if you to the login page of an user/org in a different cloud, your login doesn't work).

cc @saleiva

Hey, I actually love your latest idea about disabling login from user subdomains.

On the other hand, we would still need a solution for when an user try to login within an organization while doesn't belonging to it. For that particular scenario, I propose we do your second idea, we raise an error saying "Not a member of {organization_name}?, Go to carto.com/login"

Let me know if you need a quick mockup for that.

Yes, a mockup would be great. Specially since the organization login page can be customized and it's a bit harder to do something that looks nice in different customizations.

Thanks!

Another question: What should we do for on-premise / open source? I suggest keeping current behaviour in that case, as there is not a clear place to send the user to (no Central, so all login URLs are for an organization/user).

Sounds good to me

Hi guys, I prepared some mockups and my proposal is:

Add the copy for the login remembering to use the corporate email:

01 org login

If the user fail, change that copy to the one @javitonino proposed:

02 org login error

keep using the same behaviour for error messages with red bullets + tooltips:

03 org login error hover

@carlostallon Looks good to me! Just one detail, I would not put the domain ("@nyu.edu" in your example) in the copy because it can actually be a long list of allowed domains. Also, it might disclose some potentially sensitive data (some private email domain).

So I'd just say something generic like in the signup page: "Please, remember to use an email address belonging to this organization to login to your account.". Sounds good to you?

@javitonino you are right! updated!

Login updated

02 org login

Cool! Moving to Done in design then!

Could someone add some instructions for acceptance? Thanks!

They are in the PR :)

Let's stop this PR for a minute. I've been testing, and it breaks auto-user creation via SAML (and I'm pretty sure that via LDAP as well). Moving back to development and stopping to think about it.

For the record, knowing the proper login (or even signup) page for university org users has been a big source of confusion.

@ohasselblad Not sure what the problem is for login, since you can login from pretty much anywhere. Can you elaborate? I know about signup (which is a bit more complicated, since you can signup inside or outside the org), we have that ticket in the backburner. But it seems to me that login should not be a problem, carto.com/login works for everyone.

Sorry, you're right. Yeah, the signup was the only source of confusion.

The issue I mentioned is not an issue for now, as it only affects the SaaS. I'll document what needs to be done in https://github.com/CartoDB/cartodb/issues/11108

This can continue as it is for now, but we need to double check that Google signup into an org from the login page still works.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

santisaez picture santisaez  路  5Comments

atlefren picture atlefren  路  3Comments

makella picture makella  路  3Comments

javitonino picture javitonino  路  5Comments

piensaenpixel picture piensaenpixel  路  4Comments