Carthage: Use third-party library for semantic versioning

Created on 20 Nov 2014  路  13Comments  路  Source: Carthage/Carthage

Turns out there's already a Swift library for semantic versioning!

enhancement help wanted

Most helpful comment

I can pick this up in a couple of weeks probably. If someone is itching for it and has time before that, go ahead.

All 13 comments

Version doens't have a OS X Framework yet (See https://github.com/mrackwitz/Version/issues/2)

For what it's worth, I submitted a PR for the Mac framework target to Version, but at this point, I think Carthage's version types are powerful enough on their own and that Version might not be necessary.

I haven't looked into that one myself, but maybe it makes sense to pull ours out then?

/cc @mrackwitz

Thanks for looking into that, @eliperkins!

I haven't looked into that one myself, but maybe it makes sense to pull ours out then?

@robb Our types are fairly closely tied to what we're doing IMO, but if anyone wants to take a stab at it, I'd be happy to review a PR.

However, I'm going to close this out, as I don't think we need a backlog item for it.

There's also https://github.com/nomothetis/SemverKit, which looks pretty solid, and seems to be comparable to or a superset of our functionality.

Is this still desired after? #2412

https://github.com/nomothetis/SemverKit doesn't look very active.
https://github.com/mrackwitz/Version has made progress but I think #2412 Covers it

Looks like we Swift community do not have defacto standard library for semver yet. So sticking to our implementation which is greatly improved in #2412 makes sense to me.

We could also package our implementation as another framework in the Carthage org. Just an idea.

I would be for closing this issue or remove the labels and let StaleBot close it.
I'll let @mdiep take action here.

I like the idea of splitting it out into a separate framework. It'd probably make sense to start by making it a separate framework within the Carthage repo. But I like having a framework to enforce those boundaries.

@marcoconti83 full steam ahead? 馃槄

I can pick this up in a couple of weeks probably. If someone is itching for it and has time before that, go ahead.

Was this page helpful?
0 / 5 - 0 ratings