Carbon: Theme configurations need updating with variable-2 and variable-3 options

Created on 14 Apr 2020  路  2Comments  路  Source: carbon-app/carbon

Syntax highlighting with php seems broken

Whatever the theme I choose, syntax highlighting for PHP seems broken.

This is what it should show (as seen on codemirror demo page). It shows two different colors for variables and methods (blue and black):

79136572-86a70e80-7db1-11ea-8307-78760c8044a1

But this is what I get with "dracula" theme on carbon. It only shows one color (white) for both variables and methods:

79136596-90c90d00-7db1-11ea-8fdf-c758f179db19

This is an extract from theme's css, we should get two different colors:

.cm-s-dracula span.cm-variable { color: #50fa7b; }
.cm-s-dracula span.cm-variable-2 { color: white; }

but while inspecting I get something different:

79137460-0c778980-7db3-11ea-8186-1f537e44e015

Here is a live example, but I noticed it on most php snippets I saw on twitter: https://carbon.now.sh/1HBRbot05AIFiezO6H2n

help wanted themlanguage

All 2 comments

Thanks for posting this. Just pushed this PR (https://github.com/carbon-app/carbon/pull/988) that fixes the underlying issue, and the configuration for Dracula, but it does not fix it for other themes.

It would be _amazing_ if someone went through and set the variable-2 and variable-3 configs correctly for the other themes.

If no one else takes it, I will try and get to it eventually 馃憤

Good job, it's so much better now !

Was this page helpful?
0 / 5 - 0 ratings

Related issues

UlisesGascon picture UlisesGascon  路  3Comments

TitoMikani picture TitoMikani  路  4Comments

Gaojianli picture Gaojianli  路  3Comments

hamedmoody picture hamedmoody  路  4Comments

tibuurcio picture tibuurcio  路  4Comments