Carbon: Don't repeat photographer copyright credit

Created on 7 Feb 2020  ·  3Comments  ·  Source: carbon-app/carbon

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

bug
_Added a gif with explanation_

As you can see the copyright message keeps the previous one too.

Captura de pantalla 2020-02-07 a las 17 06 08

Expected behavior
To keep the last copyright reference only.

Info (please complete the following information):

  • OS macOS
  • Browser chrome and Brave

I can try to find the the bug a send a PR, any suggestion? BTW This is one of the most useful tool ever. You are doing a amazing job ❤️

enhancement help wanted

All 3 comments

@UlisesGascon the reason we did it this way is that we don't want to force the photographer credit _format_ on people — we want to allow people to present it how they want, and edit it (especially for other languages that don't use // for comments)

I'll leave this open, especially if others agree we should just force the format.

Thanks for the clarification @mfix22! Makes sense to me :-)

@UlisesGascon cool! 🙂 On second thought though, I think we can do better. Opening a PR now…

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jakedex picture jakedex  ·  5Comments

MelSumner picture MelSumner  ·  5Comments

NSExceptional picture NSExceptional  ·  3Comments

itaditya picture itaditya  ·  3Comments

Gaojianli picture Gaojianli  ·  3Comments