Carbon: Add Lucario theme

Created on 6 Mar 2018  ·  4Comments  ·  Source: carbon-app/carbon

Hi everyone,

I humbly want to suggest adding Lucario as an optional theme. If it's interesting for you guys, I can send a PR.

Also: I love the project! :octocat:

picture raphamorim

All 4 comments

@raphamorim Looking forward to your PR! 😄

mfix22 picture mfix22 on 6 Mar 2018

Hey @raphamorim any updates on this? We have a big release coming up and would love to include this 😄. If not, maybe one the the maintainers can submit a PR instead.

mfix22 picture mfix22 on 19 Mar 2018
🎉1

Hi @mfix22! happy to hear it :)
I already sent the PR, but it's still missing review: https://github.com/codemirror/CodeMirror/pull/5294

raphamorim picture raphamorim on 19 Mar 2018
👍1

Just merged! Codemirror right now have Lucario as theme option 🥂 -> https://github.com/codemirror/CodeMirror/blob/master/theme/lucario.css

I'll send the PR to Carbon til' end of the day.

raphamorim picture raphamorim on 20 Mar 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

sivarak picture sivarak  ·  3Comments
kievsash picture kievsash  ·  3Comments
JoeCodesStuff picture JoeCodesStuff  ·  5Comments
NSExceptional picture NSExceptional  ·  3Comments
TitoMikani picture TitoMikani  ·  4Comments