Carbon: After adjusting line-height, code selection no longer lines up.

Created on 21 Mar 2019  ยท  5Comments  ยท  Source: carbon-app/carbon

Thanks for looking at this issue / thanks in advance for fixing it! I love this little project! :D

Expected Behavior

After adjusting line-height, code selection should line up with the apparent location of the code. This would let users adjust line-height, and then continue to use the web app to create screenshots.

Actual Behavior

After adjusting line-height, code selection no longer lines up with the apparent location of the code. This makes for an unusable experience, after line-height is set. The more the line-height is changed, the worse the problem.

In the below screenshot, I have selected ALL the text (that little bump you can see at the bottom of the selection, is the closing curly brace (}) being selected.

carbon-selection-misaligned


Browser:
Chrome, Brave

help wanted

Most helpful comment

Haha, well of course I can do that, but I just thought you might want to fix the site to be more user friendly :P Iโ€™m happy with the site as it is and I use it all the time, but you have a place to submit issues, so I submitted one.

Cheers,

Joe Weaver
JoeWeaver.me

On Thu, May 16, 2019 at 5:51 PM, Michael Fix notifications@github.com wrote:

@JosephWeaver this problem doesn't seem large enough to manually keep track of the selection in code and then reapply it after the line height's change. Can you not just reselect the lines after you update the line heights?

Line heights on there own are already a rarely used feature ๐Ÿ™‚

โ€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

All 5 comments

It seems to fix itself when you try to inspect its element

Not for me! =\

Cheers,

Joe Weaver
JoeWeaver.me

On Wed, Apr 10, 2019 at 10:41 PM, Ignatius Bagus notifications@github.com wrote:

It seems to fix itself when you try to inspect its element

โ€”
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

As a work around until this is fixed, you could re-highlight the lines after adjusting the line height ๐Ÿ‘

@JosephWeaver this problem doesn't seem large enough to manually keep track of the selection in code and then reapply it after the line height's change. Can you not just reselect the lines after you update the line heights?

Line heights on there own are already a rarely used feature ๐Ÿ™‚

Haha, well of course I can do that, but I just thought you might want to fix the site to be more user friendly :P Iโ€™m happy with the site as it is and I use it all the time, but you have a place to submit issues, so I submitted one.

Cheers,

Joe Weaver
JoeWeaver.me

On Thu, May 16, 2019 at 5:51 PM, Michael Fix notifications@github.com wrote:

@JosephWeaver this problem doesn't seem large enough to manually keep track of the selection in code and then reapply it after the line height's change. Can you not just reselect the lines after you update the line heights?

Line heights on there own are already a rarely used feature ๐Ÿ™‚

โ€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

qw-in picture qw-in  ยท  3Comments

MelSumner picture MelSumner  ยท  5Comments

shaonkabir8 picture shaonkabir8  ยท  5Comments

LGTMXD picture LGTMXD  ยท  4Comments

hamedmoody picture hamedmoody  ยท  4Comments