Carbon: Solaris dark and light are both same

[M-ZubairAhmed]

Overview

There seems to be no change among themes for Solarized(dark) & Solarized(light).

Browser

Firefox 56.0 -64bit
Mozilla firefox for ubuntu
canonical 1.0

Reproduction

• I imported the code to the editor
• Toggled between two solaris themes
• No change in theme appeared

Expected Behavior

Dark solaris from atom

Actual Behavior

Dark

Light

[M-ZubairAhmed]

If this issue is revelant, i would like to work on this

[jakedex]

Reproducible on my end as well, this is definitely an issue. Thanks for reporting, @M-ZubairAhmed!

[Drarok]

I worked on this previously:
https://github.com/dawnlabs/carbon/issues/113
https://github.com/dawnlabs/carbon/pull/118

Not sure what's gone wrong between then and now!

[Drarok]

Ah ha! This commit broke it: https://github.com/dawnlabs/carbon/commit/830828d6c56ef7e0ed485d853b1b63e837594933

[M-ZubairAhmed]

would you guys still want me to go ahead with this issue or it is solved in the above pull requests?

[Drarok]

Not solved, just thought I'd lend a hand to find what the issue is since I'd worked on those themes previously. Please, go ahead. 🙂

[mfix22]

Thanks @Drarok! This will be out in the next release. Sorry about breaking it for all you Solarized fans!