Camunda-modeler: Empty OUTPUT cell in DMN can be confused with "-"

Created on 30 Jan 2020  Â·  8Comments  Â·  Source: camunda/camunda-modeler

When editing a DMN table in Camunda Modeler, empty cells are marked with a hypen / minus sign. When an actual minus sign is entered in a cell, it becomes visually indistinguishable from an empty cell.

Screenshot 2020-01-30 at 18 27 30

XML for the same is:
Screenshot 2020-01-30 at 18 32 35

On execution, the Camunda DMN engine will fail not being able to handle ${-} expression in the DMN input or output.


As a possible solution:

  • Change appearance of an empty cell in the Camunda Modeler to visually distinguish it from a cell with a minus sign
  • Add validation in Camunda Modeler to validate if entered value can be executed by the engine
  • Add validation in Camunda engine on deployment of a DMN model with invalid expression (admittedly out of scope of this repo)
DMN bug ux

Most helpful comment

We could also simply leave the cells empty, as both Excel and Google Sheets do.

All 8 comments

Thanks for reporting! We're currently re-evaluating the DMN modeling experience, which will also include the UX of decision tables.

Change appearance of an empty cell in the Camunda Modeler to visually distinguish it from a cell with a minus sign

Can you think about a solution how such a distinction could look like?

  • Add validation in Camunda Modeler to validate if entered value can be executed by the engine
  • Add validation in Camunda engine on deployment of a DMN model with invalid expression (admittedly out of scope of this repo)

That could be something for dmn-lint @barmac

Your help is very appreciated!

Screenshot 2020-02-05 at 10 38 58

How about this?

We could also simply leave the cells empty, as both Excel and Google Sheets do.

From the DMN standard perspective, what is the implication of - vs. empty string? Is there a relevant difference? If not I propose that e close this issue.

Hi @nikku , I am not sure if I understand how this relates to the DMN standard - in my opinion this could be just a UX improvement to minimise human errors

But let me know if I am missing something

Thanks for the ping back. I've re-read your issue description and figured that you are explicitly talking about _outputs_ here.

In input cells, - has special semantics (always match). In output cells that semantic does not exist. In fact, as you mention, explicitly entering - won't ever evaluate.

My proposal is: Remove the - as a placeholder from the output cells. Outputs should always be specified. This is en par with the spec.

Hi, a quote from the DMN specification:

If the input entry is ‘-’ (meaning irrelevant), every value of the input expression satisfies the input entry and that particular input is irrelevant in the specified rule.

Found on page 68 of DMN 1.1 RTF v3 clean.pdf

Hope this helps, Ingo

With v3.7 of the app we will ship an updated version of the decision table editor. This version won't show the - placeholder on outputs, thus preventing the confusion.

If you accidentally enter - it is your fault. Starting with v3.7 that issue will clearly be visible in the decision table :wink:. Thanks for your input everyone!


image

Was this page helpful?
0 / 5 - 0 ratings