Calcite-components: Question: Slot cleanup questions

[driskull]

Question

• calcite-input
  
  
  
  • should 'calcite-action' be documented as just 'action'? I think its wrong now. bug?
  
  
• calcite-dropdown
  
  
  
  • Should 'dropdown-trigger' just be 'trigger'?
  
  
• calcite-tab
  
  
  
  • Should 'tab-nav' just be 'nav'?
  
  

Helpful Details

Slot cleanup questions

[driskull]

cc @julio8a

[julio8a]

Thx @driskull, these updates would match up consistency with nomenclature across components?

[driskull]

I think so. the first one might be a doc bug but someone needs to confirm.

[jcfranco]

1. This is a doc issue: https://github.com/Esri/calcite-components/issues/2150.
2. I think we could simplify and have a consistent name for trigger slots (similar to another PR that @driskull recently submitted).
3. Similar to ☝🏼 , but no strong preference. Sidebar, is nav commonly used or do we need navigation? I know there's a <nav> element, but it has different semantics.

[macandcheese]

Sidebar, is nav commonly used or do we need navigation? I know there's a <nav> element, but it has different semantics.

We hope to tackle a true “app navigation” story this year, for which we probably (?) want to use calcite-nav (and calcite-nav-*).

Using calcite-tab-nav in tabs is a little misleading IMO, it’s really a wrapper for only calcite-tab-title children.

Maybe calcite-tab-title-group (and a resultantly named slot) ? To me it’s a more literal name, and more closely matches other instances of parent-child component nomenclature in the library (option, pick list, dropdown, tile, etc.)

[driskull]

We don't prefix any slots elsewhere with calcite- or component- so we should be consistent.

[macandcheese]

I meant a slot named ‘title-group’ based on a component of ‘calcite-tab-title-group’, but obviously that’s a much larger change to rename the ‘calcite-tab-nav’ component.

[jcfranco]

The 1st item has been addressed. For the remaining:

1. I think we can simplify.
2. Having a group component makes sense, would be consistent with others and would help avoid naming confusion if we end up introducing a nav component.

We should probably tackle these closer to 1.0.0 to batch all rename work in a single release.