Calcite-components: Bug: Value List component multiple select not working

[ethanbdev]

Summary

Recently bumped the version of Calcite Components to next.76 to use the empty color picker option and saw this issue. Shift + click and ctrl + click seem to no longer be working with a value list. Still looking into it to make sure it is not on our end, please let me know if you can repro. Thanks!

Actual Behavior

Click a value list item -> use shift + click or ctrl + click and select a different value list item -> it selects just the item clicked on even though they have the "selected" attribute

Expected Behavior

Click a value list item -> use shift + click or ctrl + click and select a different value list item -> it selects multiple items, honoring the selected attribute.

Reproduction Steps

https://codepen.io/eborgen/pen/GRjmmgE?editors=1000

Relevant Info

Update: I think this is just a visual bug with the selection, and the multi-select is working correctly otherwise. It seems like it is not allowing more than one selection in the value list even if we try to manually set multiple value list items as selected.

[jcfranco]

Thanks for reporting this, @ethanbdev!

Did a git bisect and narrowed it down to this commit: 1e3f17c61c382c8a338ed298149e7a5caddffa59 @asangma Can you take a look at this? Basically, the styling for multiple selected value list items got lost. It looked like this before:

[bstifle]

Hi yalls, where does this stand? What is the priority for this?

[bstifle]

@asangma do you have an eta?

[jcfranco]

Hi yalls, where does this stand? What is the priority for this?

Since this is a regression, I'd say high.

[subgan82]

Hi @asangma

Any update on this issue . Due to this regression we are unable to upgrade calcite components version in charts to use other calcite components fixes.

[subgan82]

The multiple selection is used with charts format UX workflows, would it be addressed as its a regression ?

[asangma]

@jcfranco It looks like value-list-item is referring to a CSS color var that isn't in CalciteColor yet...? Looks like it might be pulling from the Tailwind config.

[ethanbdev]

This looks good in the next builds now, since next.84 👍

[jcfranco]

Thanks, @ethanbdev! Closing as verified based on ☝️