Calcite-components: Enhancement: showInput on calcite-tile-select refactoring

Created on 5 Jan 2021  ·  10Comments  ·  Source: Esri/calcite-components

Summary

The showInput property has values of "left" | "right" | "none" but I think it should probably use start/end instead of left and right for RTL support.

It may also be a good time to do the following for it as well:

  • reconsider property name
  • Use interface for "start" | "end" | "none"

This would be a breaking change.

4 - verified breaking change bug convention p - high

All 10 comments

Are we ok with inputDisplay as the new name for this? cc @eriklharper

What about inputPosition? I'm ok with inputDisplay though.

-position does make sense (or -alignment) but since there's a "none" option that seems weird whereas with -display it's... slightly less weird? I don't feel super strongly 🤷‍♂️

I agree with those feelings. It's like it maybe should be split into two properties. One to deal with disabling the feature, and one to do with positioning. What do you think?

showInput (boolean) +
inputAlignment as new prop.. then we could Extract start / end from the Alignment interface instead having to create a unique one for start / end / none

showInput (boolean) +
inputAlignment as new prop.. then we could Extract start / end from the Alignment interface instead having to create a unique one for start / end / none

I like that idea, let's go with that!

Great collaboration on this guys. What's the status of this? has the naming been updated?

@macandcheese, is this is the issue you mentioned in our meeting that we can close?

Want to confirm.

Keep open until the linked pr is merged

Linked PR was merged, can we close?

Was this page helpful?
0 / 5 - 0 ratings