Cake: Add VSWhere support

[phillipsj]

As discussed in #1369 , please assign to me and I am going to try to get this added this weekend.

[phillipsj]

@devlead I already have a lot of this stubbed out. I need to think about the use cases that are supported by the tool and decide what to add. I may just add getting the installation path as that is the most needed.

[devlead]

@phillipsj getting the FilePaths first sounds good to me.

[phillipsj]

Here is currently what I have, I am still thinking through the implementation. Feedback welcomed.

https://github.com/phillipsj/cake/tree/GH1517-add-vswhere-support

[damianh]

@phillipsj great that you took this on so quickly. I think this is on critical path for cake users who need to use the new MSBuild 15 BuildTools on their CI servers. (It is for me anyway).

Open a [WIP] PR and lgtm?

[phillipsj]

That is a great suggestion, I will do it.

On Mar 5, 2017 12:18 PM, "Damian Hickey" [e-mail] wrote:

@phillipsj https://github.com/phillipsj great that you took this on so
quickly. I think this is on critical path for cake users who need to use
the new MSBuild 15 BuildTools on their CI servers. (It is for me anyway).

Open a [WIP] PR and lgtm?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cake-build/cake/issues/1517#issuecomment-284244561,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABfthUAZceelph433wUKh4mpkcjBU4F6ks5riu5XgaJpZM4MTDu6
.

[phillipsj]

@damianh The pull request is here now. I want to organize it a little differently and with a baby shower this weekend, I didn't get as much done as I would like. I am going to grab the few extra minutes I have during the week to get it finished.

[gep13]

@devlead so, this can be closed, right?

[devlead]

@gep13 correct, closed by #1520

[jnm2]

I wonder if this changes anything?
https://blogs.msdn.microsoft.com/heaths/2017/04/21/vswhere-is-now-installed-with-visual-studio-2017/

The package would only have to be downloaded if %ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe and %ProgramFiles%\Microsoft Visual Studio\Installer\vswhere.exe do not exist.

[phillipsj]

@jnm2 It would just change how the tool is found. May need to add a custom resolver that looks for it in that default location first.

[damianh]

vswherewhere