Cachet: Edit Scheduled Maintenance

[gonzoinc]

When Editing an existing Scheduled Maintenance entry, the page is auto filling the last date field to 0001-11-29 19:00 Which is causing all sorts of issues, Saving it with that date field populated removes the event as being completed form the main page, Clearing the date field out looks to do the same thing. Since the datepicker looks to only allow dates to be cycled through 10 at a time, it would take forever to get from the year 0001 to 2017, Luckily manual entry does work.

The date completed field should not even show or be required until the selection marking the event completed has been selected.

Screenshot:

[jbrooksuk]

@gonzoinc thanks for the report! What version of Cachet are you using?

[jbrooksuk]

Also, what browser are you using?

[jbrooksuk]

Fixed :)

[gonzoinc]

I cherry picked your changes and it did not fix the issue. When editing the Maintenance Event the date is still showing the '0001-11-29 19:00'. When you save the event after making updates it is still saving that date into the DB which entail removes the event form the main dashboard.

Tested in Chrome and Firefox

Using the latest release of Cachet 2.4

[gonzoinc]

I did some testing with this by removing the below from the "Completed At" input:

value="{{ $schedule->completed_at_datetimepicker }}"

This stopped the weird data from being auto entered into the field value but this exposed a second problem. Now when you edit the existing Maint event it still gets removed from the main dashboard. Going to dig through the DB data and see what values are actually changing and causing the event to be removed from the main dashboard.

[gonzoinc]

Found the problem, not sure how to fix it..... not that familiar with the code base just yet.

When you go in and edit a Maint event, if you actually make a change and save, the "Scheduled For" date gets changed to the current date/time which removes it from the main dashboard view as the view only looks for events in the future. if you makes changes and change the "Scheduled For" Datetime then it does save properly. It only breaks if you make a change to an existing event and don't make a change to the "Scheduled For" date/time.

[apssupport]

@gonzoinc Thank you for bringing this up, I can confirm that I am experiencing the same issue.

[jbrooksuk]

Hmm, looks like the created_at field isn't null in the database when it's left empty.

[gonzoinc]

Still not completely resolved. The Maint completed date looks fine now, but when you go in an edit a future event, after you save the changes the event gets removed from the main status page.

The problem is that when you actually make a change and save, the created date gets saved as the current date/time which is dropping it from the main status page.