Buttercup-desktop: Windows 10: update procedure does not work

Created on 4 Sep 2019  Â·  19Comments  Â·  Source: buttercup/buttercup-desktop

Problem

The update to 1.16.2 failed on my Windows 10 PC. After some time, I got an "EACCESS" error or something like that. I can't reproduce it, because I already found a workaround: If buttercup is run as admin, the update works.

Suggestion:

I think buttercup should be run as administrator permanently. Could you implement it so that this issue is fixed for all windows users?

Windows High Help Wanted Bug
Source
picture julianpoemp
👍1

All 19 comments

The problem is that Buttercup shouldn't need admin rights - it does nothing that warrants access to secure portions of the filesystem, or makes any system-level changes, etc..

It launches a local server for browser-extension connectivity, but this doesn't require administration. It can provide a tray icon, but this shouldn't require administration. I can't think of a single reason why admin access would be remotely necessary. I believe that forcing admin privileges would be a bandaid on the larger issue, which we don't know yet.

Buttercup is a standard user-level application that doesn't need anything administrator access has to offer, in my opinion.

If buttercup is run as admin, the update works.

I think we can still describe this whole thing as a bug: And the more people look at it, like you've said, the more it seems like it's the update process itself. We're planning on possibly killing it because of this exact issue.

perry-mitchell picture perry-mitchell on 5 Sep 2019

I think we can still describe this whole thing as a bug: And the more people look at it, like you've said, the more it seems like it's the update process itself. We're planning on possibly killing it because of this exact issue.

I don't think you have to kill this feature. Perhaps you need another update workflow. Something what other desktop applications do on Windows:

  1. Download new version as installer
  2. Run installer as admin and close current Buttercup
  3. Open Buttercup after installation

That does the owncloud client, too. It's normal that installations need admin rights, MacOSX asks for it, too.

julianpoemp picture julianpoemp on 6 Sep 2019

Well I didn’t mean kill the update system altogether, merely the one we’re using.

perry-mitchell picture perry-mitchell on 9 Sep 2019
👍1

the same here , i got a message error

karousn picture karousn on 18 Oct 2019

Hey @perry-mitchell, I think I am receiving the same error as @karousn 

Unhandled Promise Rejection
Error: New version 1.17.0 is not signed by the application owner: publisherNames: COMODO RSA Code Signing CA, raw info: {
  "SignerCertificate": {
    "FriendlyName": "",
    "IssuerName": {
      "Name": "CN=COMODO RSA Code Signing CA, O=COMODO CA Limited, L=Salford, S=Greater Manchester, C=GB",
      "Oid": "System.Security.Cryptography.Oid"
    },
    "NotAfter": "/Date(1578009599000)/",
    "NotBefore": "/Date(1546387200000)/",
    "PrivateKey": null,
    "PublicKey": {
      "Key": "System.Security.Cryptography.RSACryptoServiceProvider",
      "Oid": "System.Security.Cryptography.Oid",
      "EncodedKeyValue": "System.Security.Cryptography.AsnEncodedData",
      "EncodedParameters": "System.Security.Cryptography.AsnEncodedData"
    },
    "SerialNumber": "00BDC2D8815A5B41D6045C6C719D8A8F2A",
    "SignatureAlgorithm": {
      "Value": "1.2.840.113549.1.1.11",
      "FriendlyName": "sha256RSA"
    },
    "Thumbprint": "A9C56AD137B3A5359A375A1FA4827DDD071A845A",
    "Version": 3,
    "Issuer": "CN=COMODO RSA Code Signing CA, O=COMODO CA Limited, L=Salford, S=Greater Manchester, C=GB",
    "Subject": "CN=MadDev Oy, O=MadDev Oy, STREET=N�kinkaari 4 A, L=Espoo, S=Uusimaa, PostalCode=02320, C=FI"
  },
  "TimeStamperCertificate": {
    "Archived": false,
    "Extensions": [
      "System.Security.Cryptography.X509Certificates.X509KeyUsageExtension",
      "System.Security.Cryptography.X509Certificates.X509BasicConstraintsExtension",
      "System.Security.Cryptography.X509Certificates.X509EnhancedKeyUsageExtension",
      "System.Security.Cryptography.X509Certificates.X509Extension",
      "System.Security.Cryptography.X509Certificates.X509Extension",
      "System.Security.Cryptography.X509Certificates.X509SubjectKeyIdentifierExtension",
      "System.Security.Cryptography.X509Certificates.X509Extension",
      "System.Security.Cryptography.X509Certificates.X509Extension"
    ],
    "FriendlyName": "",
    "IssuerName": {
      "Name": "CN=DigiCert Assured ID CA-1, OU=www.digicert.com, O=DigiCert Inc, C=US",
      "Oid": "System.Security.Cryptography.Oid"
    },
    "NotAfter": "/Date(1729555200000)/",
    "NotBefore": "/Date(1413936000000)/",
    "HasPrivateKey": false,
    "PrivateKey": null,
    "PublicKey": {
      "Key": "System.Security.Cryptography.RSACryptoServiceProvider",
      "Oid": "System.Security.Cryptography.Oid",
      "EncodedKeyValue": "System.Security.Cryptography.AsnEncodedData",
      "EncodedParameters": "System.Security.Cryptography.AsnEncodedData"
    },
    "SerialNumber": "03019A023AFF58B16BD6D5EAE617F066",
    "SubjectName": {
      "Name": "CN=DigiCert Timestamp Responder, O=DigiCert, C=US",
      "Oid": "System.Security.Cryptography.Oid"
    },
    "SignatureAlgorithm": {
      "Value": "1.2.840.113549.1.1.5",
      "FriendlyName": "sha1RSA"
    },
    "Thumbprint": "614D271D9102E30169822487FDE5DE00A352B01D",
    "Version": 3,
    "Handle": 2850618952336,
    "Issuer": "CN=DigiCert Assured ID CA-1, OU=www.digicert.com, O=DigiCert Inc, C=US",
    "Subject": "CN=DigiCert Timestamp Responder, O=DigiCert, C=US"
  },
  "Status": 0,
  "StatusMessage": "Signature verified."
}
    at t.newError (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:1:8496)
    at Object.<anonymous> (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:228505)
    at Generator.next (<anonymous>)
    at Generator.c (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:1:1411)
    at d._promiseFulfilled (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:189112)
    at j._settlePromise (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:145545)
    at j._settlePromise0 (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:146143)
    at j._settlePromises (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:147495)
    at d (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:149218)
    at p (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:149157)
    at s._drainQueues (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:150677)
    at Immediate.drainQueues [as _onImmediate] (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:148899)
From previous event:
    at j.z [as _captureStackTrace] (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:164744)
    at new d (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:187987)
    at C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:191076
    at t.NsisUpdater.downloadUpdate (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:71:20764)
    at EventEmitter.i.ipcMain.on (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:414:129520)
    at WebContents.<anonymous> (C:/Program Files/Buttercup/resources/electron.asar/browser/api/web-contents.js:285:13)
ttamminen picture ttamminen on 20 Oct 2019
👍1

Thanks everyone. I did sign the executable but this time I signed it on a Windows machine (I always sign it on a mac). Seems like it hasn't worked correctly (even though I verified it again and it seemed to be ok... I will investigate. Sorry for the inconvenience.

sallar picture sallar on 20 Oct 2019

Can everyone please check to see if the issue is resolved? I deleted and re-uploaded a new version of signed windows files.

sallar picture sallar on 20 Oct 2019 
Unhandled Error
Error: spawn C:/Users/nkarous/AppData/Local/Temp/up-8ycbpR/buttercup-desktop-setup-1.17.0.exe EACCES

I think because i should have admin access to install something on my work machine.
at least show me the promp windows to logging as admin to achive the update (like many other program as virtualbox .. do when we update them)

karousn picture karousn on 21 Oct 2019

I get the same error as before.

Unhandled Promise Rejection
Error: New version 1.17.0 is not signed by the application owner:
publisherNames: COMODO RSA Code Signing CA, raw info: {
  "SignerCertificate": {
    "FriendlyName": "",
    "IssuerName": {
      "Name": "CN=COMODO RSA Code Signing CA, O=COMODO CA Limited,
L=Salford, S=Greater Manchester, C=GB",
      "Oid": "System.Security.Cryptography.Oid"
    },
    "NotAfter": "/Date(1578009599000)/",
    "NotBefore": "/Date(1546387200000)/",
    "PrivateKey": null,
    "PublicKey": {
      "Key": "System.Security.Cryptography.RSACryptoServiceProvider",
      "Oid": "System.Security.Cryptography.Oid",
      "EncodedKeyValue": "System.Security.Cryptography.AsnEncodedData",
      "EncodedParameters": "System.Security.Cryptography.AsnEncodedData"
    },
    "SerialNumber": "00BDC2D8815A5B41D6045C6C719D8A8F2A",
    "SignatureAlgorithm": {
      "Value": "1.2.840.113549.1.1.11",
      "FriendlyName": "sha256RSA"
    },
    "Thumbprint": "A9C56AD137B3A5359A375A1FA4827DDD071A845A",
    "Version": 3,
    "Issuer": "CN=COMODO RSA Code Signing CA, O=COMODO CA Limited,
L=Salford, S=Greater Manchester, C=GB",
    "Subject": "CN=MadDev Oy, O=MadDev Oy, STREET=N�kinkaari 4 A, L=Espoo,
S=Uusimaa, PostalCode=02320, C=FI"
  },
  "TimeStamperCertificate": {
    "Archived": false,
    "Extensions": [
      "System.Security.Cryptography.X509Certificates.X509KeyUsageExtension",

"System.Security.Cryptography.X509Certificates.X509BasicConstraintsExtension",

"System.Security.Cryptography.X509Certificates.X509EnhancedKeyUsageExtension",
      "System.Security.Cryptography.X509Certificates.X509Extension",
      "System.Security.Cryptography.X509Certificates.X509Extension",

"System.Security.Cryptography.X509Certificates.X509SubjectKeyIdentifierExtension",
      "System.Security.Cryptography.X509Certificates.X509Extension",
      "System.Security.Cryptography.X509Certificates.X509Extension"
    ],
    "FriendlyName": "",
    "IssuerName": {
      "Name": "CN=DigiCert Assured ID CA-1, OU=www.digicert.com, O=DigiCert
Inc, C=US",
      "Oid": "System.Security.Cryptography.Oid"
    },
    "NotAfter": "/Date(1729555200000)/",
    "NotBefore": "/Date(1413936000000)/",
    "HasPrivateKey": false,
    "PrivateKey": null,
    "PublicKey": {
      "Key": "System.Security.Cryptography.RSACryptoServiceProvider",
      "Oid": "System.Security.Cryptography.Oid",
      "EncodedKeyValue": "System.Security.Cryptography.AsnEncodedData",
      "EncodedParameters": "System.Security.Cryptography.AsnEncodedData"
    },
    "SerialNumber": "03019A023AFF58B16BD6D5EAE617F066",
    "SubjectName": {
      "Name": "CN=DigiCert Timestamp Responder, O=DigiCert, C=US",
      "Oid": "System.Security.Cryptography.Oid"
    },
    "SignatureAlgorithm": {
      "Value": "1.2.840.113549.1.1.5",
      "FriendlyName": "sha1RSA"
    },
    "Thumbprint": "614D271D9102E30169822487FDE5DE00A352B01D",
    "Version": 3,
    "Handle": 2562524665808,
    "Issuer": "CN=DigiCert Assured ID CA-1, OU=www.digicert.com, O=DigiCert
Inc, C=US",
    "Subject": "CN=DigiCert Timestamp Responder, O=DigiCert, C=US"
  },
  "Status": 0,
  "StatusMessage": "Signature verified."
}
    at t.newError (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:1:8496)
    at Object.<anonymous> (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:207:228505)
    at Generator.next (<anonymous>)
    at Generator.c (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:1:1411)
    at d._promiseFulfilled (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:189112)
    at j._settlePromise (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:145545)
    at j._settlePromise0 (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:146143)
    at j._settlePromises (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:147495)
    at d (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:149218)
    at p (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:149157)
    at s._drainQueues (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:150677)
    at Immediate.drainQueues [as _onImmediate] (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:148899)
From previous event:
    at j.z [as _captureStackTrace] (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:164744)
    at new d (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:206:187987)
    at C:/Program Files/Buttercup/resources/app.asar/dist/app.js:206:191076
    at t.NsisUpdater.downloadUpdate (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:71:20764)
    at EventEmitter.i.ipcMain.on (C:/Program
Files/Buttercup/resources/app.asar/dist/app.js:414:129520)
    at WebContents.<anonymous> (C:/Program
Files/Buttercup/resources/electron.asar/browser/api/web-contents.js:285:13)

On Mon, 21 Oct 2019 at 09:26, Nabil Karous notifications@github.com wrote:

Unhandled Error
Error: spawn C:/Users/nkarous/AppData/Local/Temp/up-8ycbpR/buttercup-desktop-setup-1.17.0.exe EACCES

I think because i should have admin access to install something on my work
machine.
at least show me the promp windows to logging as admin to achive the
update (like many other program as virtualbox .. do when we update them)

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/buttercup/buttercup-desktop/issues/805?email_source=notifications&email_token=AAH5OAINARZHU5JVW5YNMEDQPVDR5A5CNFSM4ITU3L7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBZGIXQ#issuecomment-544367710,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH5OAOBOLPF2ZG4VG2ZX2LQPVDR5ANCNFSM4ITU3L7A
.

ttamminen picture ttamminen on 21 Oct 2019

I'm quite sure, that my problem is not related to the signature issue, because my problem already existed with 1.16.2 and was caused by missing admin rights. The signature issue is another one that happens with 1.17.0, related with #826.

EDIT : I'm now not sure if my problem is different from the other issue, because it already happend with 1.16.1, related to #788.

julianpoemp picture julianpoemp on 21 Oct 2019

Update failed after I tried to update from 1.17.0 to 1.17.2. I tried it with and without admin rights.

I got this error message:
Unhandled Promise Rejection Error: New version 1.17.2 is not signed by the application owner: publisherNames: COMODO RSA Code Signing CA, raw info: { "SignerCertificate": { "FriendlyName": "", "IssuerName": { "Name": "CN=COMODO RSA Code Signing CA, O=COMODO CA Limited, L=Salford, S=Greater Manchester, C=GB", "Oid": "System.Security.Cryptography.Oid" }, "NotAfter": "/Date(1578009599000)/", "NotBefore": "/Date(1546387200000)/", "PrivateKey": null, "PublicKey": { "Key": "System.Security.Cryptography.RSACryptoServiceProvider", "Oid": "System.Security.Cryptography.Oid", "EncodedKeyValue": "System.Security.Cryptography.AsnEncodedData", "EncodedParameters": "System.Security.Cryptography.AsnEncodedData" }, "SerialNumber": "00BDC2D8815A5B41D6045C6C719D8A8F2A", "SignatureAlgorithm": { "Value": "1.2.840.113549.1.1.11", "FriendlyName": "sha256RSA" }, "Thumbprint": "A9C56AD137B3A5359A375A1FA4827DDD071A845A", "Version": 3, "Issuer": "CN=COMODO RSA Code Signing CA, O=COMODO CA Limited, L=Salford, S=Greater Manchester, C=GB", "Subject": "CN=MadDev Oy, O=MadDev Oy, STREET=N�kinkaari 4 A, L=Espoo, S=Uusimaa, PostalCode=02320, C=FI" }, "TimeStamperCertificate": { "Archived": false, "Extensions": [ "System.Security.Cryptography.X509Certificates.X509KeyUsageExtension", "System.Security.Cryptography.X509Certificates.X509BasicConstraintsExtension", "System.Security.Cryptography.X509Certificates.X509EnhancedKeyUsageExtension", "System.Security.Cryptography.X509Certificates.X509Extension", "System.Security.Cryptography.X509Certificates.X509Extension", "System.Security.Cryptography.X509Certificates.X509SubjectKeyIdentifierExtension", "System.Security.Cryptography.X509Certificates.X509Extension", "System.Security.Cryptography.X509Certificates.X509Extension" ], "FriendlyName": "", "IssuerName": { "Name": "CN=DigiCert Assured ID CA-1, OU=www.digicert.com, O=DigiCert Inc, C=US", "Oid": "System.Security.Cryptography.Oid" }, "NotAfter": "/Date(1729555200000)/", "NotBefore": "/Date(1413936000000)/", "HasPrivateKey": false, "PrivateKey": null, "PublicKey": { "Key": "System.Security.Cryptography.RSACryptoServiceProvider", "Oid": "System.Security.Cryptography.Oid", "EncodedKeyValue": "System.Security.Cryptography.AsnEncodedData", "EncodedParameters": "System.Security.Cryptography.AsnEncodedData" }, "SerialNumber": "03019A023AFF58B16BD6D5EAE617F066", "SubjectName": { "Name": "CN=DigiCert Timestamp Responder, O=DigiCert, C=US", "Oid": "System.Security.Cryptography.Oid" }, "SignatureAlgorithm": { "Value": "1.2.840.113549.1.1.5", "FriendlyName": "sha1RSA" }, "Thumbprint": "614D271D9102E30169822487FDE5DE00A352B01D", "Version": 3, "Handle": 2537510620544, "Issuer": "CN=DigiCert Assured ID CA-1, OU=www.digicert.com, O=DigiCert Inc, C=US", "Subject": "CN=DigiCert Timestamp Responder, O=DigiCert, C=US" }, "Status": 0, "StatusMessage": "Signatur wurde �berpr�ft." } at t.newError (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:1:8496) at Object.<anonymous> (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:208:228422) at Generator.next (<anonymous>) at Generator.c (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:1:1486) at f._promiseFulfilled (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:349375) at D._settlePromise (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:305779) at D._settlePromise0 (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:306377) at D._settlePromises (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:307729) at f (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:309452) at p (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:309391) at s._drainQueues (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:310911) at Immediate.drainQueues [as _onImmediate] (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:309133) From previous event: at D.R [as _captureStackTrace] (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:325005) at new f (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:348250) at C:/Program Files/Buttercup/resources/app.asar/dist/app.js:207:351339 at t.NsisUpdater.downloadUpdate (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:71:20685) at EventEmitter.r.ipcMain.on (C:/Program Files/Buttercup/resources/app.asar/dist/app.js:363:134485) at WebContents.<anonymous> (C:/Program Files/Buttercup/resources/electron.asar/browser/api/web-contents.js:285:13)

julianpoemp picture julianpoemp on 23 Oct 2019

The same issue on win10 - unhandled promise rejection, new verision 1.17.2 is not signed by owner (I am on 1.16.2 now).

tertortoise picture tertortoise on 24 Oct 2019

Probably it is the same issue as this one here.
https://github.com/electron-userland/electron-builder/issues/3667

Have you tried setting the "publisherName" in package.json? This seemed to help in one case. Obviously it has to match with the subject CN from the signer certificate ("MadDev Oy").
https://github.com/electron-userland/electron-builder/issues/3667#issuecomment-463227859

ckadluba picture ckadluba on 4 Nov 2019
👍1

Hi everyone. I understand this is becoming a big issue, but I just merged a PR that might fixed this. Thanks to @ckadluba. I'm going to try and re-release the same version to see if this issue will go away.

sallar picture sallar on 4 Nov 2019

Hi, my update issue seems to be over. I downloaded .exe file from the site and run install. It installed OK and now I am on 1.17.2. Still, when just before that I'd tried to upgrade from within an open app - it had failed with the same issue (unhandled promise rejection).

tertortoise picture tertortoise on 13 Nov 2019

Hi everyone. I understand this is becoming a big issue, but I just merged a PR that might fixed this. Thanks to @ckadluba. I'm going to try and re-release the same version to see if this issue will go away.

Too bad this didn't help. :(.

ckadluba picture ckadluba on 15 Nov 2019

Let's try to keep this item on topic - #826 is for the certificates issue, and this is for the update process w/ admin rights. Thanks everyone.

perry-mitchell picture perry-mitchell on 17 Nov 2019

Hi everyone. I have tried to upgrade electron and electron-updater to see if things improve or not. I have forked buttercup to my own personal account and release a few test versions for testing this issue. Would you mind uninstalling the current Buttercup on your Windows, and installing this version:
https://github.com/sallar/buttercup-desktop/releases/download/v1.21.0/Buttercup-Setup-1.21.0.exe
To see if it auto updates correctly to v1.22.0?
Please dont forget to uninstall it again after the test, as the versions are not correct for the official releases.

Thank you!

sallar picture sallar on 24 Nov 2019
👍1

@sallar I tested it just now on my windows pc. It works very well, thank you! (Windows 10 Pro, 64bit)

julianpoemp picture julianpoemp on 24 Nov 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

mannp picture mannp  Â·  4Comments
wtsiamruk picture wtsiamruk  Â·  6Comments
FuridamuFaita picture FuridamuFaita  Â·  3Comments
perry-mitchell picture perry-mitchell  Â·  6Comments
kimus picture kimus  Â·  5Comments